namespace
{ /// Covers sw/source/core/edit/ fixes. class Test : public SwModelTestBase
{ public:
Test()
: SwModelTestBase(u"/sw/qa/core/edit/data/"_ustr)
{
}
};
}
CPPUNIT_TEST_FIXTURE(Test, testRedlineHidden)
{ // Given a document with ShowRedlineChanges=false:
createSwDoc("redline-hidden.fodt");
// When formatting a paragraph by setting the para adjust to center, then make sure setting the // new item set on the paragraph doesn't crash:
SwView* pView = getSwDocShell()->GetView();
SfxItemSet aSet(pView->GetPool(), svl::Items<RES_PARATR_ADJUST, RES_PARATR_ADJUST>);
SvxAdjustItem aItem(SvxAdjust::Center, RES_PARATR_ADJUST);
aSet.Put(aItem);
SwWrtShell* pWrtShell = getSwDocShell()->GetWrtShell();
pWrtShell->SetAttrSet(aSet, SetAttrMode::DEFAULT, nullptr, true);
}
CPPUNIT_TEST_FIXTURE(Test, testAutocorrect)
{ // Given an empty document:
createSwDoc();
// When typing a string, which contains a "-", then make sure no memory corruption happens when // it gets auto-corrected to "–": // Without the accompanying fix in place, this test would have failed with a // heap-use-after-free:
emulateTyping(u"But not now - with ");
}
CPPUNIT_TEST_FIXTURE(Test, testDeleteSelNormalize)
{ // Given a read-only document with a fillable form, the placeholder text is selected:
createSwDoc("delete-sel-normalize.odt");
SwWrtShell* pWrtShell = getSwDocShell()->GetWrtShell();
pWrtShell->SttEndDoc(/*bStt=*/true);
pWrtShell->GotoFormControl(/*bNext=*/true);
// When you press 'delete' to type some content instead:
pWrtShell->DelRight();
// Then make sure the position after the delete is correct:
SwPosition& rCursor = *pWrtShell->GetCursor()->GetPoint(); // The full text is "key <field start><field separator><field end>", so this marks the position // after the field separator but before the field end.
sal_Int32 nExpectedCharPos = strlen("key **"); // Without the accompanying fix in place, this test would have failed with: // - Expected: 6 // - Actual : 5 // so we started to type between the field start and the field separator, nothing was visible on // the screen.
CPPUNIT_ASSERT_EQUAL(nExpectedCharPos, rCursor.nContent.GetIndex());
}
CPPUNIT_TEST_FIXTURE(Test, testRedlineReinstateSingleInsert)
{ // Given a document with a single insertion:
createSwDoc();
SwWrtShell* pWrtShell = getSwDocShell()->GetWrtShell();
pWrtShell->Insert("aaa");
SwModule* pModule = SwModule::get();
pModule->SetRedlineAuthor("Alice");
RedlineFlags nMode = pWrtShell->GetRedlineFlags();
pWrtShell->SetRedlineFlags(nMode | RedlineFlags::On);
pWrtShell->Insert("bbb");
pWrtShell->SetRedlineFlags(nMode);
pWrtShell->Insert("ccc");
// When a 2nd user reinstates that change:
pModule->SetRedlineAuthor("Bob");
pWrtShell->Left(SwCursorSkipMode::Chars, /*bSelect=*/false, 4, /*bBasicCall=*/false);
dispatchCommand(mxComponent, ".uno:ReinstateTrackedChange", {});
// Then make sure this results in a delete on top of an insert:
SwDoc* pDoc = pWrtShell->GetDoc();
IDocumentRedlineAccess& rIDRA = pDoc->getIDocumentRedlineAccess();
SwRedlineTable& rRedlines = rIDRA.GetRedlineTable();
CPPUNIT_ASSERT_EQUAL(static_cast<size_t>(1), rRedlines.size()); const SwRangeRedline* pRedline = rRedlines[0]; const SwRedlineData& rRedlineData = pRedline->GetRedlineData(0); // Without the accompanying fix in place, this test would have failed with: // - Expected: 1 (Delete) // - Actual : 0 (Insert) // i.e. reinstate didn't happen.
CPPUNIT_ASSERT_EQUAL(RedlineType::Delete, rRedlineData.GetType());
CPPUNIT_ASSERT(rRedlineData.Next()); const SwRedlineData& rInnerRedlineData = *rRedlineData.Next();
CPPUNIT_ASSERT_EQUAL(RedlineType::Insert, rInnerRedlineData.GetType());
// And when checking the undo stack:
SwUndoId nUndoId = SwUndoId::EMPTY;
pDoc->GetIDocumentUndoRedo().GetLastUndoInfo(nullptr, &nUndoId);
// Then make sure we get the relevant undo ID: // Without the accompanying fix in place, this test would have failed with: // - Expected: 153 (REINSTATE_REDLINE) // - Actual : 1 (DELETE) // i.e. the undo ID was wrong.
CPPUNIT_ASSERT_EQUAL(SwUndoId::REINSTATE_REDLINE, nUndoId);
}
CPPUNIT_TEST_FIXTURE(Test, testRedlineReinstateInsertsInSelection)
{ // Given a document with two insertions:
createSwDoc();
SwWrtShell* pWrtShell = getSwDocShell()->GetWrtShell();
pWrtShell->Insert("aaa");
SwModule* pModule = SwModule::get();
pModule->SetRedlineAuthor("Alice");
RedlineFlags nMode = pWrtShell->GetRedlineFlags();
pWrtShell->SetRedlineFlags(nMode | RedlineFlags::On);
pWrtShell->Insert("bbb");
pWrtShell->SetRedlineFlags(nMode);
pWrtShell->Insert("ccc");
pWrtShell->SetRedlineFlags(nMode | RedlineFlags::On);
pWrtShell->Insert("ddd");
pWrtShell->SetRedlineFlags(nMode);
pWrtShell->Insert("eee");
// When a 2nd user reinstates those changes with a selection:
pModule->SetRedlineAuthor("Bob"); // Create a selection that excludes the initial "a" and the last "e":
pWrtShell->SttPara(/*bSelect=*/false);
pWrtShell->Right(SwCursorSkipMode::Chars, /*bSelect=*/false, 1, /*bBasicCall=*/false);
pWrtShell->EndPara(/*bSelect=*/true);
pWrtShell->Left(SwCursorSkipMode::Chars, /*bSelect=*/true, 1, /*bBasicCall=*/false);
dispatchCommand(mxComponent, ".uno:ReinstateTrackedChange", {});
// Then make sure this results in deletes on top of inserts:
SwDoc* pDoc = pWrtShell->GetDoc();
IDocumentRedlineAccess& rIDRA = pDoc->getIDocumentRedlineAccess();
SwRedlineTable& rRedlines = rIDRA.GetRedlineTable(); // Without the accompanying fix in place, this test would have failed with: // - Expected: 2 // - Actual : 0 // i.e. a reject was performed instead of a reinstate.
CPPUNIT_ASSERT_EQUAL(static_cast<size_t>(2), rRedlines.size()); const SwRangeRedline* pRedline1 = rRedlines[0]; const SwRedlineData& rRedlineData1 = pRedline1->GetRedlineData(0);
CPPUNIT_ASSERT_EQUAL(RedlineType::Delete, rRedlineData1.GetType());
CPPUNIT_ASSERT(rRedlineData1.Next()); const SwRedlineData& rInnerRedlineData1 = *rRedlineData1.Next();
CPPUNIT_ASSERT_EQUAL(RedlineType::Insert, rInnerRedlineData1.GetType()); const SwRangeRedline* pRedline2 = rRedlines[1]; const SwRedlineData& rRedlineData2 = pRedline2->GetRedlineData(0);
CPPUNIT_ASSERT_EQUAL(RedlineType::Delete, rRedlineData2.GetType());
CPPUNIT_ASSERT(rRedlineData2.Next()); const SwRedlineData& rInnerRedlineData2 = *rRedlineData2.Next();
CPPUNIT_ASSERT_EQUAL(RedlineType::Insert, rInnerRedlineData2.GetType());
// And when checking the undo stack:
SwUndoId nUndoId = SwUndoId::EMPTY;
pDoc->GetIDocumentUndoRedo().GetLastUndoInfo(nullptr, &nUndoId);
// Then make sure we get the relevant undo ID: // Without the accompanying fix in place, this test would have failed with: // - Expected: 153 (REINSTATE_REDLINE) // - Actual : 1 (DELETE) // i.e. the undo ID was wrong.
CPPUNIT_ASSERT_EQUAL(SwUndoId::REINSTATE_REDLINE, nUndoId);
}
CPPUNIT_TEST_FIXTURE(Test, testRedlineReinstateSinglePlainDelete)
{ // Given a document with a single deletion:
createSwDoc();
SwWrtShell* pWrtShell = getSwDocShell()->GetWrtShell();
pWrtShell->Insert("abcd");
SwModule* pModule = SwModule::get();
pModule->SetRedlineAuthor("Alice");
RedlineFlags nMode = pWrtShell->GetRedlineFlags();
pWrtShell->SetRedlineFlags(nMode | RedlineFlags::On);
pWrtShell->Left(SwCursorSkipMode::Chars, /*bSelect=*/false, 1, /*bBasicCall=*/false);
pWrtShell->Left(SwCursorSkipMode::Chars, /*bSelect=*/true, 2, /*bBasicCall=*/false);
pWrtShell->DelRight();
pWrtShell->SetRedlineFlags(nMode);
// When a 2nd user reinstates that change:
pModule->SetRedlineAuthor("Bob");
pWrtShell->EndPara(/*bSelect=*/false);
pWrtShell->Left(SwCursorSkipMode::Chars, /*bSelect=*/false, 2, /*bBasicCall=*/false);
dispatchCommand(mxComponent, ".uno:ReinstateTrackedChange", {});
// Then make sure this results in an insert after a delete:
SwDoc* pDoc = pWrtShell->GetDoc();
IDocumentRedlineAccess& rIDRA = pDoc->getIDocumentRedlineAccess();
SwRedlineTable& rRedlines = rIDRA.GetRedlineTable(); // Without the accompanying fix in place, this test would have failed with: // - Expected: 2 // - Actual : 1 // i.e. reinstate didn't do anything.
CPPUNIT_ASSERT_EQUAL(static_cast<size_t>(2), rRedlines.size()); const SwRangeRedline* pRedline1 = rRedlines[0]; const SwRedlineData& rRedlineData1 = pRedline1->GetRedlineData(0);
CPPUNIT_ASSERT_EQUAL(RedlineType::Delete, rRedlineData1.GetType()); const SwRangeRedline* pRedline2 = rRedlines[1]; const SwRedlineData& rRedlineData2 = pRedline2->GetRedlineData(0);
CPPUNIT_ASSERT_EQUAL(RedlineType::Insert, rRedlineData2.GetType());
}
// When a 2nd user reinstates that change:
pModule->SetRedlineAuthor("Bob");
pWrtShell->SttEndDoc(/*bStt=*/true);
pWrtShell->Right(SwCursorSkipMode::Chars, /*bSelect=*/false, 2, /*bBasicCall=*/false);
dispatchCommand(mxComponent, ".uno:ReinstateTrackedChange", {});
// Then make sure this results in an insert after a delete: // Expected document: a<del>b<b>c\nd</b>e</del><ins>b<b>c\nd</b>e</ins>f. // First check the content.
pWrtShell->SttEndDoc(/*bStt=*/true); const OUString& rPara1 = pCursor->GetPointNode().GetTextNode()->GetText();
CPPUNIT_ASSERT_EQUAL(u"abc"_ustr, rPara1);
pWrtShell->Down(/*bSelect=*/false); const OUString& rPara2 = pCursor->GetPointNode().GetTextNode()->GetText(); // Without the accompanying fix in place, this test would have failed with: // - Expected: debc // - Actual : debc\ndef // i.e. multi-paragraph delete was inserted with a literal newline character instead of creating // a new text node.
CPPUNIT_ASSERT_EQUAL(u"debc"_ustr, rPara2);
pWrtShell->Down(/*bSelect=*/false); const OUString& rPara3 = pCursor->GetPointNode().GetTextNode()->GetText();
CPPUNIT_ASSERT_EQUAL(u"def"_ustr, rPara3); // Check if formatting was copied correctly.
pWrtShell->Up(/*bSelect=*/false);
pWrtShell->EndPara(/*bSelect=*/false);
SfxItemSetFixed<RES_CHRATR_BEGIN, RES_CHRATR_END> aSet(rView.GetPool());
pWrtShell->GetCurAttr(aSet);
CPPUNIT_ASSERT(aSet.HasItem(RES_CHRATR_WEIGHT)); // Check the redline table: now the insert redline should be multi-paragraph.
SwDoc* pDoc = pWrtShell->GetDoc();
IDocumentRedlineAccess& rIDRA = pDoc->getIDocumentRedlineAccess();
SwRedlineTable& rRedlines = rIDRA.GetRedlineTable();
CPPUNIT_ASSERT_EQUAL(static_cast<size_t>(2), rRedlines.size()); const SwRangeRedline* pRedline1 = rRedlines[0]; const SwRedlineData& rRedlineData1 = pRedline1->GetRedlineData(0);
CPPUNIT_ASSERT_EQUAL(RedlineType::Delete, rRedlineData1.GetType()); const SwRangeRedline* pRedline2 = rRedlines[1]; const SwRedlineData& rRedlineData2 = pRedline2->GetRedlineData(0);
CPPUNIT_ASSERT_EQUAL(RedlineType::Insert, rRedlineData2.GetType());
CPPUNIT_ASSERT_GREATER(pRedline2->Start()->nNode, pRedline2->End()->nNode);
}
// When a 2nd user reinstates those changes with a selection:
pModule->SetRedlineAuthor("Bob"); // Create a selection that excludes the initial "a" and the last "e":
pWrtShell->SttPara(/*bSelect=*/false);
pWrtShell->EndPara(/*bSelect=*/true);
dispatchCommand(mxComponent, ".uno:ReinstateTrackedChange", {});
// Then make sure this results in inserts after deletes:
SwDoc* pDoc = pWrtShell->GetDoc();
IDocumentRedlineAccess& rIDRA = pDoc->getIDocumentRedlineAccess();
SwRedlineTable& rRedlines = rIDRA.GetRedlineTable(); // Without the accompanying fix in place, this test would have failed with: // - Expected: 4 // - Actual : 2 // i.e. no insert redlines were created.
CPPUNIT_ASSERT_EQUAL(static_cast<size_t>(4), rRedlines.size()); const SwRangeRedline* pRedline1 = rRedlines[0]; const SwRedlineData& rRedlineData1 = pRedline1->GetRedlineData(0);
CPPUNIT_ASSERT_EQUAL(RedlineType::Delete, rRedlineData1.GetType()); const SwRangeRedline* pRedline2 = rRedlines[1]; const SwRedlineData& rRedlineData2 = pRedline2->GetRedlineData(0);
CPPUNIT_ASSERT_EQUAL(RedlineType::Insert, rRedlineData2.GetType()); const SwRangeRedline* pRedline3 = rRedlines[2]; const SwRedlineData& rRedlineData3 = pRedline3->GetRedlineData(0);
CPPUNIT_ASSERT_EQUAL(RedlineType::Delete, rRedlineData3.GetType()); const SwRangeRedline* pRedline4 = rRedlines[3]; const SwRedlineData& rRedlineData4 = pRedline4->GetRedlineData(0);
CPPUNIT_ASSERT_EQUAL(RedlineType::Insert, rRedlineData4.GetType());
}
// When a 2nd user moves into the first deletion and does reinstate-and-next twice:
pModule->SetRedlineAuthor("Bob");
pWrtShell->SttPara(/*bSelect=*/false);
pWrtShell->Right(SwCursorSkipMode::Chars, /*bSelect=*/false, 2, /*bBasicCall=*/false);
dispatchCommand(mxComponent, ".uno:ReinstateTrackedChangeToNext", {}); // Again, without an explicit cursor move:
dispatchCommand(mxComponent, ".uno:ReinstateTrackedChangeToNext", {});
// Then make sure we have insertions for both deletions:
SwDoc* pDoc = pWrtShell->GetDoc();
IDocumentRedlineAccess& rIDRA = pDoc->getIDocumentRedlineAccess();
SwRedlineTable& rRedlines = rIDRA.GetRedlineTable(); // Without the accompanying fix in place, this test would have failed with: // - Expected: 4 // - Actual : 2 // i.e. reinstate-and-next didn't create a redline & didn't move to the next one.
CPPUNIT_ASSERT_EQUAL(static_cast<size_t>(4), rRedlines.size());
}
// When a 2nd user does reinstate-all:
pModule->SetRedlineAuthor("Bob");
pWrtShell->SttPara(/*bSelect=*/false);
dispatchCommand(mxComponent, ".uno:ReinstateAllTrackedChanges", {});
// Then make sure we have insertions for both deletions:
SwDoc* pDoc = pWrtShell->GetDoc();
IDocumentRedlineAccess& rIDRA = pDoc->getIDocumentRedlineAccess();
SwRedlineTable& rRedlines = rIDRA.GetRedlineTable(); // Without the accompanying fix in place, this test would have failed with: // - Expected: 4 // - Actual : 2 // i.e. reinstate-all didn't create insert redlines.
CPPUNIT_ASSERT_EQUAL(static_cast<size_t>(4), rRedlines.size());
}
CPPUNIT_TEST_FIXTURE(Test, testRedlineReinstateSelf)
{ // Given a document with a self-insert:
createSwDoc();
SwWrtShell* pWrtShell = getSwDocShell()->GetWrtShell();
SwModule* pModule = SwModule::get();
pModule->SetRedlineAuthor("Alice");
RedlineFlags nMode = pWrtShell->GetRedlineFlags();
pWrtShell->SetRedlineFlags(nMode | RedlineFlags::On);
pWrtShell->Insert("x");
// When reinstating that insert:
pWrtShell->SttPara(/*bSelect=*/false);
pWrtShell->ReinstateRedline(0);
// Then make sure the insert and the newly created delete redlines are not compressed:
SwDoc* pDoc = pWrtShell->GetDoc();
IDocumentRedlineAccess& rIDRA = pDoc->getIDocumentRedlineAccess();
SwRedlineTable& rRedlines = rIDRA.GetRedlineTable(); // Without the accompanying fix in place, this test would have failed with: // - Expected: 1 // - Actual : 0 // i.e. the original redline was lost instead of replacing that with an insert-then-delete // redline.
CPPUNIT_ASSERT_EQUAL(static_cast<size_t>(1), rRedlines.size());
}
Die Informationen auf dieser Webseite wurden
nach bestem Wissen sorgfältig zusammengestellt. Es wird jedoch weder Vollständigkeit, noch Richtigkeit,
noch Qualität der bereit gestellten Informationen zugesichert.
Bemerkung:
Die farbliche Syntaxdarstellung und die Messung sind noch experimentell.
