|
|
|
|
Impressum ChangeLog
Sprache: Python
|
|
2025-11-05 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [8ca8d55c161d60284 4f5428fa4b58097424e324e]
Version 25.8.3.2, tag libreoffice-25.8.3.2
2025-11-05 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [534774fc97a57d13884227336ab2ed60acc0fbe1]
bump product version to 25.8.3.2
Change-Id: I2f47b1e30d8c9ee58f3af1c5a55f8fe85bf8da6b
2025-11-05 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [2e51257dc43169dde24cbf0952a039cca96c5272]
tdf#164070 always install en-US UI localization on windows
if en-US is not available, and the user didn't manually configure the UI
language, adding another language (via means of mar updater for example)
can cause that new language being used instead of the language the user
had installed initially since there's no explicit default/fallback.
Since any language that will be added in future is likely to not use a
latin script/will be quite unfamliliar to the user, having en-US to rely
on as a fallback is a much better experience.
The problem occurs on systems where the selected UI language is not
matching the windows language, so for new installations the user has to
go to options and set the language manually. That in turn then will be
an additional safeguard for further updates, since now there's a
language explicitly configured and thus no reason for LO to "guess" what
to use as default.
Change-Id: I67dd9a9ddd9de3ce79eb9144eab06b6f10134c57
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193422
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
(cherry picked from commit 51ccb1ead1c94e695489b1c494e4bf611d8b4b5c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193426
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit d74ce83da797b695d6005651f27619eec2077f28)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193430
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-11-05 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [5d7c32c486484ebda0ef782b9d4f513e98ab7835]
update credits
Change-Id: Ic382e9bc69385c1eb704341eefb08183cec8d9df
(cherry picked from commit 2be216b83d7e7755a47575b3233fa287603b6fa8)
(cherry picked from commit bed0442907e5d704e9eab81135ea8eade16448fd)
2025-11-05 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [61eaebe9d8715fa23d065fbb8b863adb2d2fb751]
Update git submodules
* Update translations from branch 'libreoffice-25-8-3'
to 7da0bbf085f28f0bb8f22602c61d91c174dbc739
- update translations for 25.8.3 rc2
and force-fix errors using pocheck
Change-Id: If22a8d2459b5c47ce71348461ec2a1c9da3727f0
(cherry picked from commit d22ab41bb76904ff6bcbe25ab70ba23bced8f58b)
2025-11-05 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [9f487c5074691a45f29e657afe9fa58d55cbdd34]
tdf#114068 allow to translate media control tooltips in navigator pane
tooltips for play/pause/stop/repeat/mute were explicitly flagged as
non-translatable for some reason. There is a media toolbar that has the
same set of controls and there could be a way to share the strings, but
they only are a handful, so not really worth a big refactoring of the UI
files for that.
Change-Id: Ia0e8e2bd664916392049df5cd537d51eb04005d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192873
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Jenkins
(cherry picked from commit 74e55a3c756c1f3ce540bf7ab575ca40a334172d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192912
Reviewed-by: Martin Srebotnjak <miles@filmsi.net>
(cherry picked from commit dae5ca06276383df0799cf2c92df5e2bb8883be2)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193457
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-11-05 Caolán McNamara <caolan.mcnamara@collabora.com> [cd8e1a8b6a863bdbd6917880302e3b770de93be8]
tdf#168672 Closing webdav documents is extremly slow
Change-Id: I9b6c1cbd7ca4c1a8bcce589cbfda5604e66520f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193404
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193428
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-11-05 Caolán McNamara <caolan.mcnamara@collabora.com> [8980b0e5d443f45404b86dbf592ebe2ffb6adc24]
Related: tdf#168672 ; cid#1642989 Wait without held lock
restore the lock at the end of SerfLockStore::stopTicker
SerfLockStore::removeLockImpl calls this, and that is called
by SerfLockStore::refreshLocks in a loop, so if it was unlocked
at the end of the first loop, then its still unlocked on a 2nd
loop.
Probably doesn't matter as there's only a 2nd unlock attempt
if m_aLockInfoMap.empty() which presumably can only happen once.
Change-Id: Iede91b1b4ef9368bcf4e62cb85bf5a0c745e0ba7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189058
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
(cherry picked from commit 3f3aed00458d64bf32f5faa25c88f959430dea3a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193403
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193427
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-11-05 Andras Timar <andras.timar@collabora.com> [e5eb1f972f28db0582e11a31387fff05f85d5ba4]
vcl: check mpWindowImpl for nullptr
Change-Id: Ib70e14cd791415f47772b1053200e9bab6925e8d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193372
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
(cherry picked from commit 4c63a86c88d54db5e69dc8502b6eeffa7f1e4417)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193393
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Jenkins
(cherry picked from commit 5946f67e1db31926af92ea3d0d8eeb58978ea782)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193399
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit bcdd61ad20635e8806993aca311a91c3cfdad6c3)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193415
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-11-04 Andreas Heinisch <andreas.heinisch@yahoo.de> [bbd19f18077882d5945063e77f3ae0db3085a934]
tdf#169108 - Create anonymous database range or data
Create anonymous database range or data during the creation of a pivot table. Otherwise, the selection changes to a old autofilter areas and the pivot table cannot be created.
Change-Id: If55b9d1204ab2ce2c3ee9a227bf0dbe1e222dbcb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193096
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
(cherry picked from commit 2a50c7fbb85941a2c50ac01257af36f132b07006)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193137
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 465e7fddb34fe06d9464ee534c79a02dd72707d4)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193143
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2025-11-04 Caolán McNamara <caolan.mcnamara@collabora.com> [c88828e302b811201171df0da50d6876410c89f0]
Resolves: tdf#144343 This isn't used to toggle navigator on/off
but instead contains a SfxBoolItem which specifies if it should
be shown or hidden and ChildWindowExecute takes care of deciding
if that requires Toggling on or off.
Change-Id: I2ad422041bb6f40f5b726111cf5ce35a32c39128
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193339
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 5e32583e755e877fd1eb68049d6f26d54fd939fe)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193360
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-11-04 Pranam Lashkari <lpranam@collabora.com> [9d308f0acc9780906167b6cec436cf22c99fc2b9]
tdf#167126: resume ScInputHandler even if error not displayed
problem:
regression from 72bbb0dd4a368dab2b1bd99917cd07d23a92a3f0
when data validity dialog was not displayed, error function returned early
this caused issue with cell invalid data cleaning and it was not possible
to enter new data in any new cell
Change-Id: I612ea8b9c651afba1095fc14726e5398484207f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193186
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Jenkins
(cherry picked from commit 0b9b82f41a1ff4cbbed6a7148b77cbc3b00c9716)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193355
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit d803223e55e5a762a6916e1c03459d931817ba70)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193358
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-11-04 Pranam Lashkari <lpranam@collabora.com> [9c89b1991e2cccf35a0a53ee5e3580f14e221388]
tdf#168261: resume ScInputHandler even if error not displayed
problem:
regression from 72bbb0dd4a368dab2b1bd99917cd07d23a92a3f0
when data validity dialog was not displayed, error function returned early
this caused issue with cell invalid data cleaning and it was not possible
to enter new data in any new cell
to reproduce:
select data validity as list and also disable error message showing
enter the invalid data in the validity cell
subsequently its not possible to type in any cells
Change-Id: Ia2157ae57ca90dd9365daae7881640a00c3f1216
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193141
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Jenkins
(cherry picked from commit 65ca233db9a39fd251ffac46608bb2714949e894)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193356
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit f60a4baee3852184da95c2947c910b485225d5fb)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193359
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-11-04 Mike Kaganski <mike.kaganski@collabora.com> [0dc4cf8c5a8427b249eff0afb8851b9113b023c2]
tdf#165733: fix leap year detection BCE
lcl_isLeapYear used a simple "is divisible" method to check if a given
year is leap. But that didn't take BCE into account: we use historical
numbering system, where before year 0001 was year -0001; and that year
was leap.
Use comphelper::date::getDaysInMonth for that, which is correct, and
also deduplicates the code. Make sure that years beyond sal_Int16 are
considered an error: they are not representable in css::util::Date,
and comphelper::date::getDaysInMonth takes years as sal_Int16.
Change-Id: I34f1ad4d5d03e05a7cf787f9997b04b1d705b583
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193302
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 97bc8766e297c8d5c22b2f6d4bd7b6d7258782fb)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193314
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit c96933d95f1eee1018f893dfc08d9b5d52891201)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193327
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-11-04 Mike Kaganski <mike.kaganski@collabora.com> [0f23205b390085be25377ff82c1452462e8149bb]
tdf#169147: handle errors creating icu::RegexMatcher
Regression after commit 38f731ff67142a423aa6f46dc3e92d094f86ffb1
(tdf#160478: fix Basic LIKE operator, 2024-04-02).
Change-Id: I4fae01e56cb91d54adba54c3787f576f60f8b1f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193202
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
(cherry picked from commit 3ab2560526ba7b745889cf509241ff17d0638cc2)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193221
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2025-11-04 Xisco Fauli <xiscofauli@libreoffice.org> [ea49312254c953f9183c015727a8d8e01aa4bf7f]
tdf#167963: patch upstream fix
See https://github.com/harfbuzz/harfbuzz/issues/5628
Change-Id: I05bffb1d5e291bd2a5f92bb87aa49bd46d9dc6b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193182
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 68822e1bfe0ed83766f4166f8162aacc7e392191)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193199
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-11-04 Caolán McNamara <caolan.mcnamara@collabora.com> [f779d55e8bcefdd9376a94ece6bfef0bda64b213]
Resolves: tdf#165265 don't autoselect a font style
If nothing was originally selected, then don't pick anything and leave
the combobox empty so the search for style feature doesn't add any
not-explicitly selected font styles by default.
Continue to restore a previously selected style, favouring the last
explicitly selected-by-user style.
Change-Id: Iad04d80305029cc3bbe3e8500ced87085645f9f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193160
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit e419d3927b62cbc90bbfd0f893adb268af38afdf)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193171
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit 54aaa6a1e475921573f07d3e5a3a1f22018574bb)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193198
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-11-04 Đoàn Trần Công Danh <congdanhqx@gmail.com> [73b8736a14391fdf6f1310cc226e289333e0cc14]
Fix memory leak with poppler-25.10.0
https://gerrit.libreoffice.org/c/core/+/192743, which fixes ftbfs with
poppler 25.10.0, unfortunately introduced a memory leak when building
with poppler 25.10.0 or later. `pOwnerPasswordStr' and
`pUserPasswordStr' ownership are supposed to be transfered to
`pDocUnique', but is now orphaned.
This change fix that said memory leak.
Change-Id: I545d461c07f033b41a4276665483b44fa401a3bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192645
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 89841fc69446a597b24b978344cd3c8d656aae09)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192934
(cherry picked from commit 1d15201503d2d17ddede4aade0ef4666e64f862b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192948
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-11-03 Caolán McNamara <caolan.mcnamara@collabora.com> [be86af4142151a10a2cd46ff0bff94019c71981d]
tdf#168979 survive broken color percentile scales
Change-Id: I3180d08272fd7355987f63f5379a044d98467cf0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192838
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192845
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192853
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2025-11-03 Michael Stahl <michael.stahl@collabora.com> [4986c9c9cc556da7c97c3a41157885dcd1fb110a]
libxslt: add patch for CVE-2025-10911
Change-Id: I951aad2bff3911f685f73390e4f42ed29fe49b41
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192444
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
(cherry picked from commit fca876c2c369b26244413fafe506acafb9d3b5bf)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192864
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2025-11-03 Xisco Fauli <xiscofauli@libreoffice.org> [7d271f90984038127550ae70ac0b0deaee5c1255]
tdf#169015: GetOutlinerParaObject might return nullptr
Regression from
commit 43e511e642a2ce7026b30ea5c212940ff3eb522e
Author: Tibor Nagy <tibor.nagy.extern@allotropia.de>
Date: Fri Nov 29 02:10:21 2024 +0100
tdf#88226 sd: fix cutting off the overflow text on the notes print page
Change-Id: I4e25760afe4bd535d1accf8291f9cbb4457625ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192895
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 9a406c26e8b8d09b99c949192bc731ba6126cef0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192907
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2025-11-03 Mike Kaganski <mike.kaganski@collabora.com> [25a24b99856a9725567fde096e7e11f0a3539ce4]
tdf#168314: check if xGraphic is empty, not Any
Regression after commit 9d6e1594a298c9d41f3dc64ad80edf4b9868c2e8
(Deduplicate and unify using vcl::GetBitmap, 2024-11-08).
An Any with an empty graphic is not itself empty; such an any caused
the outer check to succeed, and therefore its 'else' branch never
executed, when it ought to.
Change-Id: I97115c7f7dbab4ec54b5e999e4b47ecdc8874e47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193161
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit a8216f500c223797b13976678924b76c5effec65)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193170
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit da6b70633ac6bf78ce0a68022518396a2c650970)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193184
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-11-03 Stephan Bergmann <stephan.bergmann@collabora.com> [1fc462b65dd9656b576de716ceeb223eca4da76f]
Fix presumed | vs. & typos
...introduced in 25e08e4ea0df956f46bd7ef81493fcf5a5c1879c "Resolves: tdf#164920
add scrollbar width to desired size if enabled" and causing
> svx/source/tbxctrls/linectrl.cxx:435:15: error: bitwise or with non-zero value always evaluates to true [-Werror,-Wtautological-bitwise-compare]
> 435 | if (nBits | WB_VSCROLL)
> | ~~~~~~^~~~~~~~~~~~
> svx/source/tbxctrls/linectrl.cxx:576:15: error: bitwise or with non-zero value always evaluates to true [-Werror,-Wtautological-bitwise-compare]
> 576 | if (nBits | WB_VSCROLL)
> | ~~~~~~^~~~~~~~~~~~
Change-Id: I6f77cd30f3b98abb15afb665b336fba13d46ee01
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192963
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
(cherry picked from commit ad6e817e38545903f5fbbe11a2dcb033e5affead)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192968
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 656a79ed1365851e7f8b0f3dacb29321c0264b6b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193021
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2025-10-24 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [96d44dad3c06fe2decfacea5d4dccf4b6e9bdfd0]
update credits
Change-Id: Id71076a39bde8f6c01283e207773f80b3acbb6e2
(cherry picked from commit b65b00d904f8ae1c84c9dbdd9e6629080aee858a)
(cherry picked from commit 216c31600970374b12a5f2aaf6d9f91098e1aa4c)
2025-10-22 Caolán McNamara <caolan.mcnamara@collabora.com> [3a08160072f04e172364115161002699078eaacc]
crash in GetPercentile with empty std::vector first arg
/opt/collaboraoffice/program/../program/libsclo.so
(anonymous namespace)::GetPercentile(std::vector<double, std::allocator<double> > const&, double)
sc/source/core/data/colorscale.cxx:624
/opt/collaboraoffice/program/../program/libsclo.so
__gnu_cxx::__normal_iterator<std::unique_ptr<ScColorScaleEntry, o3tl::default_delete<ScColorScaleEntry> > const*, std::vector<std::unique_ptr<ScColorScaleEntry, o3tl::default_delete<ScColorScaleEntry> >, std::allocator<std::unique_ptr<ScColorScaleEntry, o3tl::default_delete<ScColorScaleEntry> > > > >::operator*() const
/opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_iterator.h:1096
/opt/collaboraoffice/program/libscfiltlo.so
ScHTMLExport::WriteCell(sc::ColumnBlockPosition&, short, int, short)
sc/source/filter/html/htmlexp.cxx:923
/opt/collaboraoffice/program/libscfiltlo.so
ScHTMLExport::WriteTables()
sc/source/filter/html/htmlexp.cxx:864
/opt/collaboraoffice/program/libscfiltlo.so
ScHTMLExport::WriteBody()
sc/source/filter/html/htmlexp.cxx:699
/opt/collaboraoffice/program/libscfiltlo.so
ScHTMLExport::Write()
sc/source/filter/html/htmlexp.cxx:313
/opt/collaboraoffice/program/libscfiltlo.so
rtl::OUString::operator=(rtl::OUString const&)
include/rtl/ustring.hxx:586
/opt/collaboraoffice/program/../program/libsclo.so
ErrCode::IgnoreWarning() const
include/comphelper/errcode.hxx:102 (discriminator 1)
/opt/collaboraoffice/program/../program/libsclo.so
rtl::OUString::~OUString()
include/rtl/ustring.hxx:546
/opt/collaboraoffice/program/libmergedlo.so
TransferableHelper::SetObject(void*, unsigned int, com::sun::star::datatransfer::DataFlavor const&)
vcl/source/treelist/transfer.cxx:912 (discriminator 1)
/opt/collaboraoffice/program/../program/libsclo.so
ScTransferObj::GetData(com::sun::star::datatransfer::DataFlavor const&, rtl::OUString const&)
sc/source/ui/app/transobj.cxx:395
ScColorScaleFormat::CalcValue is optimized out, but it has to be
case COLORSCALE_PERCENTILE and getValues() must return an empty vector
Change-Id: I2cf09f19edcb5f30c82eca02e2a0fe95e86c78db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192823
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192837
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192844
Tested-by: Jenkins
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192852
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-22 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [68e15c9e131377b92e9a2f166cdcb9e17b44aad6]
bump product version to 25.8.3.1.0+
Change-Id: Ib6fd97222de796d78a8cfc6fc3b2df08aaaa070d
2025-10-22 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [025d9ad90aee99dfa9f2c99d9e302d0442c1542b]
Branch libreoffice-25-8-3
This is 'libreoffice-25-8-3' - the stable branch for the 25.8.3 release.
Only very safe changes, reviewed by three people are allowed.
If you want to commit more complicated fix for the next 25.8.x release,
please use the 'libreoffice-25-8' branch.
If you want to build something cool, unstable, and risky, use master.
2025-10-22 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [a366c2e4aa71a416411ae0c40347ccf6f6ddcdaa]
Update git submodules
* Update translations from branch 'libreoffice-25-8'
to 17df49cf269a1e1917dc5d4347db00a3dd92bab0
- update translations for 25.8.3 rc1
and force-fix errors using pocheck
Change-Id: Ie174d7556325e998d0f7a2e9eb3bfcc9bb93ea6f
2025-10-22 Caolán McNamara <caolan.mcnamara@collabora.com> [b77b59adca898565b88b38a0d5b6b51fcda52f1b]
Resolves: tdf#164920 add scrollbar width to desired size if enabled
Change-Id: Ib6e354d5a4a9076b81e6a26fe78bdd4994024ec1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192755
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 25e08e4ea0df956f46bd7ef81493fcf5a5c1879c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192810
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-10-22 Michael Weghorn <m.weghorn@posteo.de> [fa68edb7bbe54c71b7c9507412b1812d2c20b0ff]
a11y: Set mnemonic-widgets in password dialog again
They were dropped in
commit 1791a290a82591d5b0609502e86f07ed69acee5c
Date: Sun Mar 9 13:27:57 2025 +0530
tdf#146947 Add show/reveal toggle to "Set Password" dialog
for no apparent reason, resulting in the Orca
screen reader no longer announcing the text
of the label that describes what the entry
is for.
Example to trigger the dialog:
* start Writer
* "File" -> "Save As"
* check the "Save with Password" checkbox
* hit OK button
Change-Id: Ifbb9c6e69254cf5f9439fcfd5347e845ba09f96a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192820
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
(cherry picked from commit 8ceea0574dbfd84d06ec367c44454e69a1ec5af3)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192828
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-22 Xisco Fauli <xiscofauli@libreoffice.org> [9394454f9e79634d31562e26eb5d1fc868419f3f]
nss: upgrade to 3.117
Downloaded from https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_117_RTM/src/nss-3.117-with-nspr-4.37.tar.gz
Change-Id: If381a7686a6d3db93e45778855ec74ee90be426b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192799
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit b168b52022d59e79dc2c3a9ebdb1b8b968b9c3e2)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192804
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-10-22 Xisco Fauli <xiscofauli@libreoffice.org> [225263fb51e19032a0aa0fef93778308df648898]
python3: upgrade to 3.11.14
* Add external/python3/setuptools.patch.1 to deal with the space
in Lib/setuptools/_vendor/jaraco/text/Lorem ipsum.txt
Downloaded from https://www.python.org/ftp/python/3.11.14/Python-3.11.14.tar.xz
Change-Id: I0fe4730ee26267e0042fb10b6ad78bbc21ca1ce5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192784
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-10-22 Xisco Fauli <xiscofauli@libreoffice.org> [1e667fa90e602b89fa3d198897aa85c7cdd01cea]
glm: upgrade to 1.0.2
Downloaded from https://github.com/g-truc/glm/archive/refs/tags/1.0.2.zip
Change-Id: I07b5bc3a63d0dbe196b38f81ef9329ac44c962cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192781
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
(cherry picked from commit a6080387f85b0018c31060b05e0d223e1541e0f4)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192794
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-10-22 Xisco Fauli <xiscofauli@libreoffice.org> [a96851ee7e3201d719a032d0f85c064eaa7a269e]
poppler: upgrade to 25.10
Downloaded from https://poppler.freedesktop.org/poppler-25.10.0.tar.xz
Change-Id: I05f89f4177312a148a5a15cd1f1b206d1dc01a86
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192743
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
(cherry picked from commit ae83e577501c504f89b434606f05ff1d555729c9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192754
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-10-22 Xisco Fauli <xiscofauli@libreoffice.org> [c6315f9834a446b9d2ba831ac53781cc7bd5546e]
libgpg-error: upgrade to 1.56
Downloaded from https://gnupg.org/ftp/gcrypt/libgpg-error/libgpg-error-1.56.tar.bz2
Change-Id: I6aeb7723e94cffe6bdcad8cd6af74891210c4d26
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192709
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
(cherry picked from commit 802328a6055106d4bf1ecaba6db1b6cc473b96fd)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192741
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-10-22 Mike Kaganski <mike.kaganski@collabora.com> [e6875a474b394a9d01bd6c05414d8e704f8bb29a]
tdf#168980: don't use shape Z-order to identify shapes
The problem was wrong identification of the shape type, because of
unreliable use of fragile Z-order.
XMLShapeExport::exportShape used xShape's Z-order to get the info
collected for current xShape. Value of Z-order is calculated in
SwXShape::getPropertyValue; it takes into account text boxes of
shapes, which affects the correction in SwTextBoxHelper::getOrdNum.
The correction results in several different objects returning the
same Z-order. And in the specific document, the information that
was collected for a rectangle object, was used for an object of
different type.
Instead of trying to find a smart way to continue using Z-order,
this change uses XShape itself as the key into the map of info,
similar to how XShapes objects are used as keys into ShapesInfos.
Change-Id: Iacbc101623504db4290ad2c283351c4141b2d1b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192796
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 0dc93fddcc751a28cfdb936f61bb6f0f4812e4b9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192805
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-10-21 Khaled Hosny <khaled@aliftype.com> [0704f03eca87491f87381a2fa995f1920bb19151]
tdf#168884: Restore missing transparency in EMF files
Revert unrelated changes from:
commit 1bdf1e2d52a7fae3e1a58ddf15a7657df3d47004
Author: Khaled Hosny <khaled@aliftype.com>
Date: Thu Sep 25 16:33:09 2025 +0300
tdf#168371: Disable ligatures in Impress/Draw with character spacing
I added a new parameter to TextSimplePortionPrimitive2D constructor, and
rTextFillColor that previously was using the default value had now to be
explicitly set, but I should have used COL_TRANSPARENT as that is the
default.
Change-Id: Ie51e8f3f4c68a9539eb3f6cc77fb1e6cf44f673f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192779
Reviewed-by: Khaled Hosny <khaled@libreoffice.org>
Tested-by: Jenkins
(cherry picked from commit 1dce54d8fb070d3d4134317612c145a923497bb4)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192788
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-21 Aron Budea <aron.budea@collabora.com> [30ca1deeebbdb3cf69816fe65401d91e36596717]
tdf#168885 oox: save more of empty charts
Otherwise Word will complain.
Affected types: area, bar, bubble, line, stock.
Regression from 3b4c11350a631e27345e87ecfe258d12983cbfbc.
Change-Id: I56d533d9c55bae45240a1b51733ff60f47b1b2e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192483
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga@collabora.com>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192782
2025-10-21 Miklos Vajna <vmiklos@collabora.com> [7afa99daab032723aabdeea00d6d69cf97928434]
tdf#166319 sw interdependent redlines: fix redo of direct reject for format
Open the bugdoc, select the format part of the insert-then-format
redline in the manage changes dialog, reject, undo, redo: the result is
<ins>AAA</ins>BBB<ins>CCC</ins> instead of one big insert redline.
Similarly, open the other bugdoc with a delete and a format redline in
it, select the format part of the delete-then-format redline in the
manage changes dialog, reject, undo, redo: the result is
<del>AAA</del><format>BBB</format><del>CCC</del> instead of one big
delete redline.
What happens is that the UI action uses
sw::DocumentRedlineManager::RejectRedlineRange(), while the redo uses
sw::DocumentRedlineManager::RejectRedline(), and while the first
supported direct accepts, the later did not.
Fix the problem by:
1) In sw::DocumentRedlineManager::RejectRedlineRange(), create the undo
action with the correct depth & directness for direct rejects
2) In DocumentRedlineManager::RejectRedline(), use use
lcl_RejectOuterFormat() to directly reject a format redline instead
of the usual lcl_AcceptRejectRedl(), which gives us matching behavior
for the UI action & the redo.
Writer's interdependent redlines are now in a reasonable state with
this: actions for the redline under cursor work with ins/del when
possible (looking "through" format); while the manage changes dialog
still allows working on the format redline directly if that's wanted.
Change-Id: Idb90dfbd86ac26ff51da8a34731ea75a48748bdf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192015
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192736
2025-10-21 Miklos Vajna <vmiklos@collabora.com> [fbec8ab124b58779567e14428238136baa1e84d6]
tdf#166319 sw interdependent redlines: fix redo of accept for fmt on ins/del
The bugdoc has <ins>AA<format>BB</format>CC</ins> content, accepting the
BB part "directly (via the sidebar or the manage changes dialog, so you
accept the format, not the underlying insert), then undo, then redo
resulted in <ins>AA</ins><format>BB</format><ins>CC</ins> instead of a
single insert, as expected.
What happens is that the UI action uses
sw::DocumentRedlineManager::AcceptRedlineRange(), while the redo uses
sw::DocumentRedlineManager::AcceptRedline(), and while the first
supported direct accepts, the later did not.
Fix the problem by:
1) Extending SwUndoRedline with a flag to know if the accept/reject to
be performed by redo should be a direct action or not
2) Fixing sw::DocumentRedlineManager::AcceptRedlineRange() to create an
undo action with the correct depth (should be 0, was 1) & save the
direct flag into the undo action
3) In sw::DocumentRedlineManager::AcceptRedline(), use
lcl_AcceptOuterFormat() to accept a format redline directly instead
of the usual lcl_AcceptRejectRedl().
This also fixes the case where you have a format on top of a delete
(instead of an insert).
Change-Id: I78d7ae9eebf8525191a3d9b3a1731d80ad04a75b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191960
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192735
2025-10-21 Miklos Vajna <vmiklos@collabora.com> [772189ecaca99338672d94aeb1f34abb836b7f3e]
tdf#166319 sw interdependent redlines: allow accept/reject for fmt on ins/del
When a format redline is on top of an insert/delete and the uno command
is dispatched to accept/reject the redline under cursor, then we always
interact with the insert/delete, ignoring the format. This is usually
wanted, but now there is no way to interact with the format redline,
even if you would explicitly ask for it.
Notice that the manage changes dialog/sidebar has a separate row for the
format redline and the ins/del redline under it (at the same document
model position), so that gives us a way to select the format redline
explicitly and interact with it.
Implement this by adding a "direct" mode to the edit shell's
AcceptRedline() / RejectRedline().
With this, all of the (insert or delete) then format, (accept or reject)
on it case works in direct mode. Undo also works, redo still needs
fixing.
Change-Id: I7947cd6c7264773d51e63ccd7c45acb001a79d88
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191592
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192734
2025-10-21 Jim Raykowski <raykowj@gmail.com> [55d72acdba8e55ff44da1534d7c9426fc89a6063]
tdf#168929 fix cannot rename objects with CJK languages via Navigator
Change-Id: I11fa5106d63b78a4aacb144ed70ac658607611a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192704
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
(cherry picked from commit 4f053ee1b55faa9deec3cbf7cb88f265458b20e0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192739
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-10-20 Mike Kaganski <mike.kaganski@collabora.com> [b2947edc956ebd42b994ff08a96ec0fa43a2ec90]
tdf#164677: separator properties in XMLTextColumnsPropertyHandler::equals
When collecting autostyles, each added autostyle is compared with the
already added ones. If all the properties match, new autostyle is not
added, but an existing one is used.
For text columns, the comparison procedure only compared things defined
in XTextColumns interface, and ignored all properties of TextColumns
service - so, styles only differing in those properties were considered
identical, and only the first of them was saved and used for all cases.
This had never been implemented properly; all versions I tested, did the
same, so I doubt it was a regression. But indeed, it was a bug.
Change-Id: I0042067499a904a66ffb10b4f4ce4115d86e6cfb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192639
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192684
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-20 Xisco Fauli <xiscofauli@libreoffice.org> [fbb1d7bcba219685d789c2f4cdf348f8f7f8d696]
related tdf#168511: bundle venv on mac too + Add test
I missed it in
commit dd8c42bf4b6eb5f692bb929547f69a9aedcf6c0c
Author: Xisco Fauli <xiscofauli@libreoffice.org>
Date: Tue Sep 23 10:07:26 2025 +0200
tdf#168511: python3: bundle venv
Change-Id: I180df8df27ece92aaa1feca379d280ff3f1ba2de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191392
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191398
2025-10-20 Xisco Fauli <xiscofauli@libreoffice.org> [ecda1df6a14e99d5713309b786ff9137dda4767e]
tdf#168511: python3: bundle venv
Change-Id: I5d4b03571099486b981f83b0487cdcbc4dd7a1a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191377
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
(cherry picked from commit dd8c42bf4b6eb5f692bb929547f69a9aedcf6c0c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191386
2025-10-20 Justin Luth <jluth@mail.com> [92307cad6a66f4fc891f566b9a40832971b198f4]
tdf#162461 Revert "tdf#129924 docx import: set background color"
This reverts 6.4.1 commit 9476dfe7d1b86b367966e7dedf67e11936c8d9d7
Automatic font-color needs to be exported as automatic,
not some hard-coded value based on some background whatever.
There were lots of fixes related to "highlight" verses "shade"
backgrounds in 7.x, so this hackery would be obsolete anyway.
Change-Id: Ic62fe56c74cffd8c8475befe745e9fb1c227ec1c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192518
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
(cherry picked from commit 74063178d58d30706c68003ee8ad8e6053f8df50)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192695
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-20 Mike Kaganski <mike.kaganski@collabora.com> [05d1d307e83431f2e1e649ffe3c1f0854b44d13a]
tdf#168673: approx equality threshold no less than 1/2 15th significand
01:26,47 is 0.001000810185185185, which has 16 significant decimals. It
is converted to string as "0.00100081018518519" (15 significands).
The problem was, that when criterion "=0.00100081018518519" is used to
check value 0.001000810185185185, the two numbers differ in five least
significant bits, but rtl_math_approxEqual uses 0x1p-48 to ignore last
four bits only. This is a common problem for numbers close to 1.0E(N).
This change introduces a second threshold, in addition to "only take
into account 48 signigicant bits of mantissa": it calculates the value
of half of 15th decimal unit of the smaller absolute value, and uses
the greater of the two thresholds for the approximate equality.
Change-Id: I2f98ab23c94ca3a2949c3762fbfb6ea563eef94b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191883
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
(cherry picked from commit d32c664c3df302b7107a70858aa55b11601225cf)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192696
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-20 Miklos Vajna <vmiklos@collabora.com> [e2b2ecad7a0ffdf1e0c34ec70c1987698971cbad]
tdf#165615 sw floattable, no overlap: avoid check against an own follow
Load the bugdoc, the layuot loop control kicks in:
warn:sw.layout:20117:20117:sw/source/core/layout/tabfrm.cxx:1853: LoopControl in SwContentFrame::CalcLowers
and then the content is laid out on 3 pages, while it fits 2 pages in
Word.
What happens is that the document has an inline table, then a floating
table inside that. The inner floating table has tblOverlap set to
'never', and then things go wrong in
SwToContentAnchoredObjectPosition::CalcOverlap().
Fix the problem by checking if the two overlapping fly frames are
actually next to each other in a split fly chain: if we're the precede
of the other fly, then no need to worry about the overlap, that follow
fly will move to the next page anyway.
In theory this would be also interesting for toplevel floating tables,
too -- but in practice CppunitTest_sw_core_layout's testSplitFlyHeader
shows doing this in general would need more work, so just do this for
floating tables which are inside tables.
Change-Id: I4d0f1bd5229f8fbc3bb49af57f88fd6ef911cbfe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192433
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
(cherry picked from commit 72e79a4d75cbbc8615fe9815bbbe9a38780ff856)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192717
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-20 Miklos Vajna <vmiklos@collabora.com> [153a8942c7c9070dbcbb398d90f126ea5ba1a775]
tdf#162730 sw floattable: fix when inside an inline table, with hide mark
Open the bugdoc, it has an outer inline table, then an inner floating
table. The inner table is split, but both parts of it stay on page 1,
leading to overlapping text.
This document's outer table has a single row and a single cell, but the
cell has a <w:hideMark> property. If that's missing, the inner floating
table is split properly.
Fix the problem by ignoring <w:hideMark> in case the cell's only content
is a floating table: in this case setting the row's size type to "fix"
would not be correct anyway.
Regression from commit 2d43c34333076fad092f0cdc0f60f81580acdbee
(Related: tdf#55160 sw floattable, nested DOCX imp: fix inner tbl at
cell start, 2023-09-15).
Change-Id: Ia9759a1c8ebaaa22b547a5ff250fa9dcf7ffbe4a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192512
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
(cherry picked from commit 25ab6816990b688bf12004280664fb3810996f1c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192716
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-20 Mike Kaganski <mike.kaganski@collabora.com> [80850b7d086e2b0fc7f792130cce951d5d946573]
tdf#167326: Let CalcHeightWithFlys take hidden frame state into account
Table cells use that function to calculate the min cell height. In the
bugdoc, sections inside a cell contained flys, and were hidden. When
the min cell height was calculated, the sections' flys were considered,
despite they were hidden.
Change-Id: Ie5a8fb54a1c9fe21cc5f4d474bd24feabb660330
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192232
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
(cherry picked from commit 0ba44065385cbee7c490cf4a97641c19edc79a63)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192713
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-20 Mike Kaganski <mike.kaganski@collabora.com> [58561ba4dea22e59b7a7fb36170d574cbbcae936]
tdf#168817: don't emit hyperlink markup for Ruby portions
It produced incorrect markup like
<text:a ...><text:ruby ...><text:ruby-base>...</text:a></text:ruby-base><text:ruby-text>...</text:ruby-text></text:ruby>
after commit c50fbdceafdd4b857954f098e38cae03e8bc6064 (tdf#148198: merge
identical hyperlinks of adjacent text ranges on ODF export, 2022-07-18).
Only the inner Text portions need an 'a' element.
Change-Id: Ia5a0b671b5d454b0e9d4dab0295b57249db9f4dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192249
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192683
2025-10-20 Mike Kaganski <mike.kaganski@collabora.com> [1aac67235256b90479de733d178bfe6a955a1888]
OUStringLiteral -> OUString
Change-Id: I124ab59b49493a0ca8b052b6f7c0347fae64e765
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192252
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192729
2025-10-20 Jonathan Clark <jonathan@libreoffice.org> [768b67b1b727d93134dba1efd624000b57b653a2]
tdf#166044 sw: Fix cont. footnotes repeating the dest page number
Fixes an issue causing Writer to print the destination page number twice
in footnotes with continuation notices that end in non-Latin text.
This was happening due to subtle mismanagement of the m_bHasFollow flag.
Continuation notices rely on this flag being unset to indicate the field
portion responsible for printing the destination page number, but the
layout algorithm was leaving this flag unset on two different portions.
In Latin-only documents, this bug was hidden by SwLineLayout::CalcLine()
removing the second portion, but this isn't possible when a script
change is involved.
Regression since commit 6c0105307efa15837e9e5287103995312f373b67
(sw: fix stale SwNumberPortion follow flag)
Change-Id: I94c6f7ca75a3cf844d3eff2640d63777ac026717
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192464
Tested-by: Jenkins
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
(cherry picked from commit 23a0a5d5d2d004c85e6230040d4d1475e79f48fc)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192726
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-20 Justin Luth <jluth@mail.com> [482871586febdea7d5ccef815f8ad33ffb40c095]
tdf#157365 sw: apply colorConfig change to SwModule
This fixes a 7.6 regression from
commit 1916d161902bdd52b8cfa5b29153c8f8c39fce52.
Changes made were not immediately applying to new documents,
and perhaps not even to the current document
if the user also looked at SwModule options.
Change-Id: I5fa21cac57ab1bbfc96b9d6d2b7f403b32103e84
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192410
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
(cherry picked from commit 2b0bc0ed83cc0ec03ea30570dc7538df22f303b1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192724
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-20 Mike Kaganski <mike.kaganski@collabora.com> [aa690147e302325bfbdc44c1fada42e7c59966e5]
tdf#168777: Trailing space must show all decorations, also for ODF
Commit 853e13f9146e83b959bc53152ec103470d55fb4f (tdf#57187: make sure
to put trailing blanks to hole portion in narrow lines, 2023-12-30)
caused a regression, where trailing whitespace lost its decorations.
Commit a877c6ce97f73906c39cf800bc61d7d99847361c (tdf#164487: Introduce
"Show underline" MS Word compatibility option, 2025-02-26) took care
of the Word compatibility case, and introduced a compatibility flag
matching respective flag in Word. It only handled underline, as the
flag name in Word implied.
It turns out, that (1) Word's flag, despite its name, controls all
decorations of trailing writespace (highlignting, strike-out); and
(2) before the original commit, Writer's default was to show all the
decorations as well. Which means, that there is only one case when
the decorations must be omitted: if "Word-compatible trailing blanks"
is enabled, but "Underline Word-compatible trailing blanks" is off.
This change is intended to show trailing space's underline, overline,
strike-out, border, and highlighting correctly.
Change-Id: I68d0aaaa0a7b9610ec817728bd4acad92ef26fe1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192191
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit b36f181bb71c395f9c48c6358bea550ac4767839)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192712
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-20 Jonathan Clark <jonathan@libreoffice.org> [13c6bc02d4c60e6aa35ae2145db431cfe8ae6dba]
tdf#72341 sw: Make inc/dec font size affect all scripts
This change updates the FN_GROW_FONT_SIZE and FN_SHRINK_FONT_SIZE
handlers to scale fonts for all script types, even if the
currently-selected text does not contain a particular type.
This fixes the reported issue that bullets in RTL context are not
resized if a selected list item does not contain CTL characters. This
also fixes the broader issue of inserted text not reflecting earlier
size changes, simply because the script type for that inserted text
wasn't present at the time.
Change-Id: I881f0b90b5c3aecbbf2e40ee2ad6758de9c5bad3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192459
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
Tested-by: Jenkins
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192725
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-20 Aron Budea <aron.budea@collabora.com> [2c0f2c55ab43f39e54e8df9164665dd7544d8658]
tdf#168921 sw: don't export user fields with empty names to DOCX
Otherwise Word will complain.
Started from ae5f469d3893de73850ccc369dbf426a4acd8f15.
Change-Id: I223bcea33645e02972bc189eef0b913fc19b3b48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192583
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Jenkins
(cherry picked from commit bd01fe073f0ef0eae54f6e9a6d4ecce68171d1c9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192691
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-20 Mike Kaganski <mike.kaganski@collabora.com> [05a0f70a417dbe71ca7b580d6e62c0a7977a0c72]
Some DDE fixes
It seems that some DDE code was virtually never tested in our CI.
That resulted in several unnoticed regressions.
In commit 81b954718f0cdac6873927e869b3e41f863562e7
(loplugin:unnecessaryvirtuals, 2015-06-09), DdeService::MakeTopic
was made non-virtual. That broke its use on Windows, where a derived
class used to override that method (which of course didn't use the
'override' keyvord, hence went unnoticed).
In commit 88e3b846b8a4bd4ce5507d1bc5441ee4167e5326 (remove some dead
bits of DDE, 2016-04-06), DdeService::MakeTopic was finally dropped.
In commit c026b936404bd052fc74283d3cc2e0727ec4edb9 (no need to
allocate SfxDdeDocTopics_Impl separately, 2023-02-28), a check in
SfxApplication::AddDdeTopic was changed from testing if pDocTopics
were initialized to checking if they are empty. The new test made
adding anything to the vector impossible.
This change tried to make it functional again, and adds a (Windows-
only) unit test.
To enable unit test, we need an app name, so that DDE is initialized
properly. Also, ImplDdeService::MakeTopic had a condition to exit
early, when !Application::IsInExecute(). Here we allow to add it, if
unit test is running.
SfxDdeDocTopic_Impl::Put ismodified to store OUString to the Any -
see ScByteSequenceToString::GetString. Without the change, UTF-16
was treated as 8-bit-encoded string.
theDdeInstData in svl/source/svdde/ddecli.cxx is now not a pointer,
bus a function-local static. No need to delete it: it has nothing
that needs to be released. Before, it could get destroyed too early,
preventing DDE from working.
DdeConnection::~DdeConnection could reliably deadlock, when it had
a connection to the server in the same process; processEventsToIdle
is called now to avoid that.
DdeData ctor taking OUString is fixed: xImp->nData is bytes, not
characters.
Change-Id: I9a151eebc65a26b76c9f6134e97cd1f4d2e2b615
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192640
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192690
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-20 Miklos Vajna <vmiklos@collabora.com> [7e0713ad8a2b06c9ffd5b5d83b2a28fe1d7012a4]
sc: fix crash in SparklineGroupsContext::onCharacters()
Fixes this assertion failure in a crash report:
/opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_vector.h:1230: constexpr std::vector<_Tp, _Alloc>::reference std::vector<_Tp, _Alloc>::back() [with _Tp = oox::xls::Sparkline; _Alloc = std::allocator<oox::xls::Sparkline>; reference = oox::xls::Sparkline&]: ;Assertion '!this->empty()' failed.
Backtrace from gdb on the core:
#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1 0x00007f906206e7f1 in __GI_abort () at abort.c:79
#2 0x0000000000af43ee in std::__glibcxx_assert_fail(char const*, int, char const*, char const*) ()
#3 0x00007f904d07ff87 in std::vector<oox::xls::Sparkline, std::allocator<oox::xls::Sparkline> >::back (this=<optimized out>)
at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_vector.h:1228
#4 std::vector<oox::xls::Sparkline, std::allocator<oox::xls::Sparkline> >::back (this=<optimized out>) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_vector.h:1228
#5 oox::xls::SparklineGroupsContext::onCharacters(rtl::OUString const&) ()
at sc/source/filter/oox/SparklineFragment.cxx:232
#6 0x00007f905cf0988a in oox::core::ContextHandler2Helper::processCollectedChars() ()
at include/rtl/ustring.hxx:546
#7 0x00007f905cf09a05 in oox::core::ContextHandler2Helper::implEndElement (nElement=3475622, this=0x7f902403e880)
at oox/source/core/contexthandler2.cxx:123
gdb also points out that m_aSparklineGroups is non-empty.
Change-Id: Ib368550f6db0ed7ce4fbe37e056cd416208e7fe9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192424
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
(cherry picked from commit cde426b7dbea32f93607130d13f108330a8b6275)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192721
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-10-20 Miklos Vajna <vmiklos@collabora.com> [7422b7b60631f0f43fad7781d9f4b0e7fb5a4fb8]
sd: fix crash in SdDrawPagesAccess::remove()
Crashreport signature:
> kit-1853625-1853625 2025-10-05 16:19:13.871457 +0000 [ kitbroker_02b ] SIG Fatal signal received: SIGSEGV code: 1 for address: 0x100
...
> program/libmergedlo.so
> SdrUndoPage::SdrUndoPage(SdrPage&)
> svx/source/svdraw/svdundo.cxx:1308
> program/libmergedlo.so
> SdrUndoDelPage::SdrUndoDelPage(SdrPage&)
> svx/source/svdraw/svdundo.cxx:1383
> program/libmergedlo.so
> std::_Head_base<0ul, SdrUndoAction*, false>::_Head_base<SdrUndoAction*&>(SdrUndoAction*&)
> /opt/rh/devtoolset-12/root/usr/include/c++/12/tuple:200
> program/libsdlo.so
> SdDrawPagesAccess::remove(com::sun::star::uno::Reference<com::sun::star::drawing::XDrawPage> const&)
> sd/source/ui/unoidl/unomodel.cxx:5181 (discriminator 4)
and gdb on the coredump says:
> #5 0x000070373442496a in SdDrawPagesAccess::remove (this=0x6caee6e0, xPage=...)
> at /home/collabora/jenkins/workspace/build_core_co-25.04_for_online_snapshot/sd/source/ui/unoidl/unomodel.cxx:5181
> 5181 rDoc.AddUndo(rDoc.GetSdrUndoFactory().CreateUndoDeletePage(*pNotesPage));
> (gdb) print pNotesPage
> $5 = <optimized out>
> (gdb) down
> #4 SdrUndoFactory::CreateUndoDeletePage (this=<optimized out>, rPage=...) at /home/collabora/jenkins/workspace/build_core_co-25.04_for_online_snapshot/svx/source/svdraw/svdundo.cxx:1763
> 1763 return std::make_unique<SdrUndoDelPage>(rPage);
> (gdb) print &rPage
> $6 = (SdrPage *) 0x0
so check for the case when pNotesPage is nullptr.
Change-Id: I1033d5196b329cb648fd27ac2633833a723f47a8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191948
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit 81c26f3c3f9c3b3672b6bbc34605d121ffaa1b72)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192718
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-10-20 Miklos Vajna <vmiklos@collabora.com> [8acfabf1f8bbb444d4fc3275a897da0aa0830e5e]
tdf#168688 DOCX import: fix missing char props in field in header in ToC
Regression from commit 6ee33d0772f991f04e97b5b61d7b11810a1b8ac0
(tdf#104079 RTF import: fix handling fields inside TOC fields,
2017-10-17), open the bugdoc, check the font size of "TEST" in the
header, it should be 24pt, but it's 12pt.
What happens is that the document ends with the table of contents DOCX
field, so the section properties at the end of the document (including a
reference to a header) get parsed while the ToC field is still open, so
we think that m_xTOCMarkerCursor is in use, but it's for the body text
and we're in the header, so it's not relevant.
Fix the problem by moving m_xTOCMarkerCursor to m_StreamStateStack,
where all state that should be stashed away & restored later belongs.
This way the old tdf#104079 use-case keeps working and the new use-case
gets fixed.
Interestingly this xTOCMarkerCursor is not actually used as a cursor
anymore and it just indicates if we're inside a ToC or not, but leave
that unchanged in this commit.
Change-Id: I1d1c9f55413d94dcde9e7c715bc9f9863f354dcb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192392
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
(cherry picked from commit 86d0a2f84d714da67d83fdba652540ebe1027382)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192720
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-10-20 Mike Kaganski <mike.kaganski@collabora.com> [8a8cf61700d08e166ff206f2d291a16f5f6662ee]
tdf#167676: do not run updater tasks in headless mode
Also reorder conditions to only check environment variables after normal
registry settings.
Change-Id: Idac6d7135da366dabf9285310d445925e9e4d1a9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192113
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
(cherry picked from commit 02f93a9d1763336eb655ec13d1cfd1e114246b34)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192711
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-10-20 Mike Kaganski <mike.kaganski@collabora.com> [fb8332fd4ac068835ba3a6557e8a67c5a5006559]
tdf#167143: set text of the correct row
Regression after commit 00e2762c664614a1b33f54dfc990ba29f0f81a07
(Drop uses of css::uno::Sequence::getConstArray in cppuhelper ..
cui, 2024-04-29).
Change-Id: I9544160ee3857c3ef8322c85529f5ff6a4ce0e2c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192055
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
(cherry picked from commit f5cd16a252a73a3e594fc19eba365c52ec987fbb)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192710
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-10-20 Justin Luth <jluth@mail.com> [1b6d78398021ebaf59b7d1d3579aab1ba2242d1e]
tdf#114343 titlepage: DoSpecialInsert (Alt-Enter) when necessary
If the document starts with a TOC or a table,
then the title page wizard (Format - Title page)
fails to (properly) insert a page before.
(note that while it DID insert a page before the TOC,
that para-with-page-break is all still "part of the TOC"
and so when the TOC is refreshed, the page break is lost.)
make -srj1 UITest_writer_tests5 \
UITEST_TEST_NAME=titlePageWizard3.tdf114343.test_tdf114343 \
SAL_USE_VCLPLUGIN=gen
make -srj1 UITest_writer_tests5 \
UITEST_TEST_NAME=titlePageWizard3.tdf114343.test2_tdf114343 \
SAL_USE_VCLPLUGIN=gen
Change-Id: I0eb865259889601c0918096d8dd51fc50d0dca52
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191164
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
(cherry picked from commit 932c8227717f44877d77659c444845d39f4156ce)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191356
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-10-20 Michael Stahl <michael.stahl@collabora.com> [015b61daec58227263bf05defe97a03c92762dc5]
configure: openssl 3.0.18 evidently needs perl Time::Piece
Can't locate Time/Piece.pm in @INC (you may need to install the Time::Piece module) (@INC entries checked: ...) at Makefile.in line 37.
Change-Id: Ia47eeb971f7bf91972f46be46330f10e64682799
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191735
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
(cherry picked from commit 0622d8d160b54b120e3955b6b0e177a2a25ca0d1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191752
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-10-20 Caolán McNamara <caolan.mcnamara@collabora.com> [8d5da57c259a3a3d09a0118846c75a269bf38cdf]
Threaded import crash in ScDocument::ShrinkToDataArea
since possibly(?) https://gerrit.libreoffice.org/c/core/+/180773
one thread, importing sheet 0, uses ScDocument::ShrinkToDataArea
for a range on sheet 1 while sheet 1 is importing on a different
thread.
Change-Id: Ia982e4c0af4859aacbca19420941f19ee85479eb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191920
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
(cherry picked from commit 7a6ebc8be8f5df795d1c9e0cca1a740ee2b62b27)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191986
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-10-20 Mike Kaganski <mike.kaganski@collabora.com> [1ef44db022c76ea28aa63aa3243a8660fb5d061c]
tdf#168723: realloc should create the _correct_ size before access ;-)
This is how commit 36df0b837b398f1011cb6f9fdf978a24125eee89 (INTEGRATION:
CWS os47 (1.3.190); FILE MERGED, 2005-01-28) desctibed the same change
in commitPage. The leftover's time came, just after 20 years.
Change-Id: Id960f84349b8885811ad750d5956965d0ccf47b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191981
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 014612657286b8042580245773934c5a9433503b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192697
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-10-20 Mike Kaganski <mike.kaganski@collabora.com> [5219ea7b98bb35fc9f4ec39f25ebfafb7346bc25]
tdf#168750: Make sure that class module is recognized on load
The problem appeared, when a macro loaded a library with a class module,
that had a public element (e.g., a function) with the same name, as used
for a local variable in the macro without a prior DIM.
Normally, there is a precaution in SbModule::Find, which hides the names
in class modules. However, this precaution failed during load.
The reason was, that the flag identifying the module as a class module
was set only when the module got compiled. It turned out, that first, it
is parsed in SbModule::SetSource32 only partially, with minimal work to
recognize the names (and a few other small things). At this stage, it is
not marked as class module yet; and when the clashing name is looked up,
it gets found in the module. Then its value is requested; at this point,
the module gets compiled, and the "class module" flag is set; then, if
the class module element tries to use another name from the same module,
it fails, which produces visible error message.
This change makes sure, that the initial fast parse stage also checks
Option ClassModule, to set it properly. Also it drops redundant variable
bIsProxyModule from SbModule, because mnType already contains the needed
type information. And lastly, it reorders SbModule::Find a bit, to avoid
searching a module, only to discard the result immediately, because it's
a class module.
Change-Id: I8add9873bf31fb767b64d27a36aef8e3a89a0de0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192075
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192689
2025-10-20 Miklos Vajna <vmiklos@collabora.com> [0ca27b0abb86898effe7d28d1e7786aa8027cd33]
xmlsec: upgrade to 1.3.8
Downloaded from
<https://www.aleksey.com/xmlsec/download/xmlsec1-1.3.8.tar.gz>.
Remove 0001-const-up-xmlSecErrorsTable.patch, which is upstream already.
Change-Id: I633ed7ecc90b8d798aa9ae03a4237fda4cf26b47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192476
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit d56e6cc6ec7807155e56bb7c59aabe5f8f885beb)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192688
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-10-20 Aron Budea <aron.budea@collabora.com> [8602573b3b9509702d8df15128488e032e825c6e]
tdf#168754 sd: escape comments exported to PPTX
Change-Id: Ic0574980ec3d837f7747aaeb54fb8925aff2987f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192072
Tested-by: Jenkins
Reviewed-by: Aron Budea <aron.budea@collabora.com>
(cherry picked from commit 6cab4cb50cf67a8dd595fffa107968cb1bd9fd18)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192083
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-10-20 Mike Kaganski <mike.kaganski@collabora.com> [2b8c4cdb286102a848a711259089ba87ef08d9ee]
Related: tdf#168842 Don't truncate source precision in vcl::TextToValue
When user enters a value like "2.54cm", and current input box is points,
which has only one decimal digit, it does not make sense to apply that
precision to the input string, making it mean "2.5cm" (and resulting in
70.9 pt).
This change adds a function to convert such strings to double, instead
of sal_Int64; then the double is handled using vcl::ConvertDoubleValue,
as before.
Now entering "2.54cm" produces the expected 72.0 pt.
This needed some OUString->u16string_view for loplugin:stringviewparam.
Change-Id: I5afa4edada904c4d8b8bcd9df65243546cb6bd00
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192663
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-10-19 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [e05e6af1ee3af91ed59da5c30fbd38e12d1f3c37]
tdf#167704 fix gallery themes not using translations
regression from d81808ec15064e7655503253dddb8ebdc58b1b29
it is not substr(startPos, endPos) but substr(startPos, length)
so the code ended up with the whole remainder of the key: 'langCode]'
instead of just 'langCode' and that broke the lookup.
Change-Id: I33eddf566e2d453dff14c123fc6c8cda97382b2d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192573
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
(cherry picked from commit 961439e8e6f7a5a179bcdd092254dd1f32a1c7c5)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192672
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-19 Noel Grandin <noelgrandin@gmail.com> [0056bfa3fccc4f50ae0dccf70be01aed55583e93]
tdf#168744 editting format of writer input field asserts
Fixing two bugs here. To trigger these bugs, try to do:
open bugdoc
right-click -> edit fields
and then change the selected date format
and then click OK
First I have to remove an assert added in:
commit 99055ae98ef1fe67b8db4a8c3167a8acaeaac02f
Author: Michael Stahl <michael.stahl@allotropia.de>
Date: Fri Feb 2 20:10:24 2024 +0100
tdf#123968 sw: fix assert on importing ooo62823-1.sxw
Which makes no sense, because we use those values all over
the place in SwSetExpField, and this assert does not
seem to be related to the rest of that bugfix.
Secondly, we have to fix a cast and then a check in
SwFieldPage::InsertField.
SwFieldTypesEnum::Input can, for better or worse, either
refere to an SwInputField or an SwSetExpField, so we
cannot cast to an SwInputField BEFORE we have checked if
it is actually an SwInputField.
Also the condition we were checking here is the wrong way
to determine what kind of subclass this is.
Change-Id: I92c0047a2a3662d3184aad2ec06f565e306d5407
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192067
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
(cherry picked from commit 388af2c059533adb773fa9a4ebda577da523509c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192089
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-19 Justin Luth <jluth@mail.com> [26f5e07563f6f95dc2f9e00b9eb4315aa0e2951a]
tdf#99205 sw options: don't lose automatic spell checking status
This patch fixes Tools - Options - Writer
from mistakenly turning off the automatic spell checking.
The SwModule m_pUsrPrefs is created early,
before a view has been created,
so the default value of bOnlineSpell(false)
might still be in effect.
Since "ApplyItemSet" doesn't at all control IsOnlineSpell,
pull the global value from the current view,
so that we don't get a mistaken change in ApplyUsrPref
if( !(*pSh->GetViewOptions() == *xViewOpt) )
{
//is maybe only a SwViewShell
pSh->ApplyViewOptions( *xViewOpt );
Change-Id: I761ce6c04ee45b7f228615be57bf6235c3e18fe2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192585
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
(cherry picked from commit a2de588c344f24f8f2e359d6f2b736fc4fba0a80)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192667
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-19 Michael Weghorn <m.weghorn@posteo.de> [fd3605fbcea46ca35bdeaaa5dd5f8a8b5016e0f9]
linux_aarch64: Fix Android build with NDK 29
An Android build including autogen options
--with-android-ndk=$HOME/Android/Sdk/ndk/29.0.14206865
--with-distro=LibreOfficeAndroidAarch64
failed like this:
.../bridges/source/cpp_uno/gcc3_linux_aarch64/cpp2uno.cxx:604:29: error: cannot initialize a parameter of type 'char *' with an rvalue of type 'unsigned char *'
604 | __builtin___clear_cache(const_cast<unsigned char *>(begin), const_cast<unsigned char *>(end));
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
1 error generated.
Tweak the version check introduced in
commit 28e542dc61d408f5807e8c94ed48c273146edbda
Date: Wed Apr 23 13:17:21 2025 +0200
Avoid loplugin:redundantcast on macOS with recent LLVM 21 trunk
...including
<https://github.com/llvm/llvm-project/commit/b6b025797245a5e5416b522df041252e3c4ff868>
"Fix the signature for __builtin___clear_cache (#134376)", which now caused
> bridges/source/cpp_uno/gcc3_linux_aarch64/cpp2uno.cxx:601:9: error: redundant reinterpret_cast, result is implicitly cast to void pointer [loplugin:redundantcast]
> 601 | reinterpret_cast<char *>(const_cast<unsigned char *>(begin)),
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> bridges/source/cpp_uno/gcc3_linux_aarch64/cpp2uno.cxx:602:9: error: redundant reinterpret_cast, result is implicitly cast to void pointer [loplugin:redundantcast]
> 602 | reinterpret_cast<char *>(const_cast<unsigned char *>(end)));
> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
to not expect the new signature for Android NDK <= 29,
for which __clang_major__ is 21, but which doesn't have the
relevant commit mentioned in the commit message quoted above.
The NDK 29 release notes mention [1]:
> Updated LLVM to clang-r563880c. See clang_source_info.md in the toolchain
> directory for version information.
~/Android/Sdk/ndk/29.0.14206865/toolchains/llvm/prebuilt/linux-x86_64/clang_source_info.md
contains this:
> Base revision: [386af4a5c64ab75eaee2448dc38f2e34a40bfed0](https://github.com/llvm/llvm-project/commits/386af4a5c64ab75eaee2448dc38f2e34a40bfed0)
That referenced llvm-projects commit
386af4a5c64ab75eaee2448dc38f2e34a40bfed0 is indeed before
the b6b025797245a5e5416b522df041252e3c4ff868 one mentioned
above.
[1] https://github.com/android/ndk/wiki/Changelog-r29
Change-Id: I88419d0d8d47563d6d0d236dc17806979e56c831
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192378
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
(cherry picked from commit 1ccb2ecd4e3e883e7a715b0b0f13c2e57d120b45)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192402
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-19 Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk> [7574ddff417e9767a7c1c1285fc50ee51f41caed]
tdf#164927 allow Theme dialog to be customized in menu/toolbar
Change-Id: I157474d2ff0bc060d717e373f98eb50729b8645c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192564
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
(cherry picked from commit f1c96d118a29e4f406c88ca9202ec6b317c89df2)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192599
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-19 Mike Kaganski <mike.kaganski@collabora.com> [d0b3b1086cf6fe7c8160bd08b69cf375b44a6b88]
Related: tdf#168842 digits in GtkSpinButton, lost in SRC -> UI conversion
The digits setting may only apply when the current unit is point: see
SetFieldUnit, which special-handles the unit. So the omission of the
setting went unnoticed for a long time.
This is similar to commit 75b30f1d107f45aebbf9a0811b9d40f4b2bafdce
(tdf#168842 Issue entering paragraph values in cm, when default is in
points, 2025-10-15), and tried to handle the rest of omissions in UI.
Change-Id: Ia348e29b268c5f49dc9eedc24262d30efbb8faa5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192636
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
(cherry picked from commit f6df8fc72f9bcab541554cd98859304f34d19f21)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192659
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-17 Regina Henschel <rb.henschel@t-online.de> [3ba0ea447d88856da2e08db3ad3b12c0a7f622d3]
tdf#168861 tooltip line wrap for length > 100 char
The current threshold is 150 characters. However, this results in very
wide normal tooltips that are hard to read. Therefore, the threshold is
reduced to 100 characters. The value 100 was chosen because it is
currently already used as threashold for cases where the text contains
line breaks.
If the tooltip length is smaller than 100 characters, the tooltip is
displayed in a single line. This behavior does not change with this
patch.
The threshold was introduced for OOo bug i42424 to force a line wrap
in the footnote balloon rectangle that is shown when you hover over
a footnote anchor with the mouse.
I don't know how to test the width of such a temporary tooltip
rectangle in a unit test. Thus a unit test is missing.
Change-Id: I7e4c47e5212f0af2510878ef2c3d6475d1d5ba46
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192458
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
(cherry picked from commit 34612217f8a027b940169899eb5c5514155649df)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192570
2025-10-15 Bogdan Buzea <buzea.bogdan@libreoffice.org> [6dacd3417222825e3bdfb1420fafcd4b2abe4eb5]
tdf#168842 Issue entering paragraph values in cm, when default is in points
Change-Id: Ib954a05bc9bea2db72b37da803a192f645e127b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192405
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 75b30f1d107f45aebbf9a0811b9d40f4b2bafdce)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192422
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2025-10-13 Julien Nabet <serval2412@yahoo.fr> [7b00f09c09f24b403102decc1f205b51bdcbaeaf]
Fix f5f228ea9d5abd24e6e6fc332b383894ec6d2d8c
Only the first change was right.
The other one is wrong, console log showed
(soffice:82981): GLib-GObject-CRITICAL **: 20:52:50.810: g_object_new_is_valid_property: property 'label' for type 'GtkCheckButton' cannot be set twice
Change-Id: Iab3528a6c181e2af20690977586395e52e0f3240
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191515
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Jenkins
(cherry picked from commit ba6ae8bfdb3f92f5d8f702c40f1c281754378234)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192324
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2025-10-13 Mike Kaganski <mike.kaganski@collabora.com> [c5500e388884785cc7590832d321353467abcb6d]
Deduplicate some code that clamps values
Change-Id: I7581863235c93eacbffd3bea7fe2733a97395b17
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192239
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit dc33e6bbcd3132036eff1069834348ea67de8cee)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192257
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-12 Mike Kaganski <mike.kaganski@collabora.com> [4c9a19587ffe26606f7664ae6272767b20c32609]
tdf#168709: set decimal digits for Page dialog's metric controls
Regression after commit 7ba10e2d317a53763e1aff55a85546bfdac12fc5
(Convert page format tab page to new widget UI, 2013-02-27).
Before the change, in cui/source/tabpages/page.src there were
'DecimalDigits' for all metric controls, set to 2. The commit
didn't set any digits in the UI file that replaced page.src.
The adjustment of the metric fields happens in SetFieldUnit; if
the current unit is point, then the result of the adjustment will
depend on the pre-set digits; when there was none, it stays none.
This change restores 2 decimal digits in the UI.
Change-Id: I98ed501825e1c9115f992441cbd28a089fe0a234
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192236
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 81c707a4aa897d2793aa3f40dd08295ab7e019c9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192255
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-12 Mike Kaganski <mike.kaganski@collabora.com> [bb821267b55541e515087b598054502ec450840b]
tdf#168709: round double value instead of truncation
Regression from commit cfff893b9c82843a90aac4ecdb3a3936721b74a0
(Move unit conversion code to o3tl, and unify on that in more places,
2021-02-14).
Change-Id: If18e8537cd03d3fd516bd164c6a816f1bba38f7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192235
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit dd544837226d9af2a777c145f91972fd0b755587)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192254
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-12 Caolán McNamara <caolan.mcnamara@collabora.com> [f335e5b73193912a2ceda2e577093e80e98e27a7]
ofz Use-of-uninitialized-value
Change-Id: I3dfc1296e174d6751300991f214e99b09d745e5c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192189
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-12 Caolán McNamara <caolan.mcnamara@collabora.com> [7796d3e5522f0cdb6508362cbd9b49255ec866cc]
ofz Use-of-uninitialized-value
Change-Id: I6a80b3e16f904d50e72c03bab25164e03f192a21
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192186
Tested-by: Jenkins
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-10 Heiko Tietze <tietze.heiko@gmail.com> [61fdfed5372c2e914ff735377a591d17451054aa]
Resolves tdf#154443 - Use Colibre fallback for page shadow
Change-Id: Ieadfbea52304686d6af609d7a211c74510f8a91b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192096
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
(cherry picked from commit fbbbc56214d4a1fa72bb2453ad0f321294ad8049)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192143
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-10 Dev Lo <lodev@ossii.com.tw> [e4063dc67bd79aa34d23de292b6b462d9339304f]
tdf#146101 Filter Context prop in Notebookbar Extension tab and menu
Shows correct icons in Extension tab, and correct extensions in the
right-hand dropdown menu
Change-Id: I6902fc3fe380841356d4c5753cb326df62305d11
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191418
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
(cherry picked from commit f44eca0ace11a195b0516a6cadab9be0a4857331)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191995
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-07 Heiko Tietze <heiko.tietze@documentfoundation.org> [f8a323604ed37f916236d3a8b640732b93a2a568]
Resolves tdf#168610 - MacOS main icon should respond to icon style
Requires some transparency that macOS can fill with dark/clear/tinted
values. To achieve this, the white background of the main icon and its
shadow was removed temporarily and the icon expanded to fill the space.
Change-Id: Ib82b457c038ff237c7f3b60441ec915a91d040e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192008
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
(cherry picked from commit c1c340425d8c842e73f546b0803e026672c77fc6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192042
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-07 Patrick Luby <guibmacdev@gmail.com> [811a901f6242e9dd7d01a050ad9cb793a555a0d4]
tdf#168711 Ignore marked text in -[SalFrameView selectedRange]
While -[SalFrameView attributedSubstringForProposedRange:actualRange:]
looks at marked text, -[SalFrameView selectedRange] should only return
selected text.
Change-Id: I8145f6d186cb4d17a50c545929bde3023caddd62
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191989
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
Tested-by: Jenkins
(cherry picked from commit 0f6d14dbe7f0f5a50a28ea8b796a8a97de756487)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192041
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-07 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [cb0271065184716e247c222410878ce444cd2e58]
Update git submodules
* Update translations from branch 'libreoffice-25-8'
to 8580a1686ad62f6cc2960447d96855315e3a1117
- update translations for 25.8
and force-fix errors using pocheck
Change-Id: Iae167d1fe7905971d19ac26f99bcd6c34c3c155a
2025-10-06 Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> [5a597640883526f80a466dcebbdc6d69ad6a61be]
Update git submodules
* Update helpcontent2 from branch 'libreoffice-25-8'
to fee16ab5d16ee912ac40010c9ebed311ac5991ed
- Revert "tdf#151551 Help Updates for Hyperlink Dialog"
This reverts commit 10793e69187eaa6092dad7943dbf78b2e6f556f1
Change-Id: I718176c8417becd3de44ce99b37fc1abc07b5046
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/191833
Tested-by: Jenkins
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
(cherry picked from commit 67cf1084e0f8897deb522fc9bd8b8a47776b2c02)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/191956
2025-10-06 Michael Stahl <michael.stahl@collabora.com> [dc06c589ef2a97a84570c4b14a9fbcc6670f13aa]
tdf#167205 package: fix writing Zip64 local headers
This would be reported on reading as an 8-byte gap at the position where
a 32-bit DD for the entry would end.
The problem is that if flag bit 3 is set, and the uncompressed size
exceeds 2^32, writeDataDescriptor() will write 8-byte sizes, but the
Zip64 extension header is missing - the latter should also write 0 even
though the APPNOTE doens't appear to require it.
4.3.9.2 [...] When extracting, if
the zip64 extended information extra field is present for
the file the compressed and uncompressed sizes will be 8
byte values.
Also make sure that the ZipEntry nSize member actually contains the
uncompressed size, which is somewhat tricky, but is required in
writeLOC() to check if Zip64 is needed. (Assume that the DEFLATEd size
is never larger than uncompressed, which is true for every XML file).
Change-Id: I611e6ffda12d8e6953e9306dc4a4407be8e725a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191185
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Michael Stahl <michael.stahl@collabora.com>
(cherry picked from commit abfdc11fa45610f38d00999f66416c66a868426a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191719
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-03 Xisco Fauli <xiscofauli@libreoffice.org> [6b124070e695649bb1480b32a15acfa606ee9738]
openssl: upgrade to 3.0.18
Downloaded from https://github.com/openssl/openssl/releases/download/openssl-3.0.18/openssl-3.0.18.tar.gz
Change-Id: Ie24873924bf8a0f9d3edb37e4e69e2e64b25ce47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191693
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
(cherry picked from commit b9abb977cbdc90ffc5c60ac5307cede571c168d7)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191694
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-03 Michael Weghorn <m.weghorn@posteo.de> [f36e68a9085d02317997f64faedb685054d56589]
tdf#168646 vcl: Forward unhandled tooltip event to base class
In VclDrawingArea::RequestHelp, if the drawing area specific
logic doesn't provide a tooltip text to show, call the base
class implementation, instead of returning without doing
anything.
This ensures that the extended tip logic implemented in
Window::RequestHelp is triggered as expected when
those are enabled.
Change-Id: I2918cc3377ec53e649d54cceaf0c9cb53effe58f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191801
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
(cherry picked from commit 9adbd5a71dca00de4d2323883a01ae4e7c02dc97)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191804
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-03 Jonathan Clark <jonathan@libreoffice.org> [dd6c84ccf72e02f921664b9954425b19793bc245]
tdf#136663 sw: Remove extra spacing between Hangul and non-CJK scripts
Previously, Writer would add a kern portion between any CJK text and any
non-CJK text. This is the correct behavior for Chinese and Japanese,
which add a small amount of extra space between CJ characters and
non-CJK text as a typesetting convention. This behavior is not, however,
a convention of Korean typesetting.
This change corrects Writer so it no longer inserts this extra space if
the involved CJK characters are Hangul.
Change-Id: I711df97fca55cb8c26809ac5549871f2407bbfaa
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191756
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
Tested-by: Jenkins
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191761
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-03 Xisco Fauli <xiscofauli@libreoffice.org> [426beb0fe20753ebc60c43149d27fe38d7d0257e]
harfbuzz: upgrade to 12.1.0
Downloaded from https://github.com/harfbuzz/harfbuzz/releases/download/12.1.0/harfbuzz-12.1.0.tar.xz
Change-Id: I693d354139b8ce0e06b41dfb4a90381321762eb8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191767
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191792
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-03 Xisco Fauli <xiscofauli@libreoffice.org> [ad1cc6c7e34dff03604a4ae5978d5efd8712d8ca]
harfbuzz: upgrade to 12.0.0
Downloaded from https://github.com/harfbuzz/harfbuzz/releases/download/12.0.0/harfbuzz-12.0.0.tar.xz
Change-Id: Ib0010a2ef897b7c2ef5f75ba8eea15d2ecf365e8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191631
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit e6bcb4ae0d958a53b40dfc0c88f4f7d7f98d677f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191640
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-02 Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> [87de4e9da06aa91e6bd92bbd2d4c0b81d22c5d7a]
Revert "tdf#151551 Remove frame target option from Hyperlink dialog"
This reverts commit 74147823a7c933c796239b00cd9bf89edb899eb3.
The terminology in the dialog confused the reporter and implementers
and a useful feature was accidentally removed. The feature may be
simplified later, but let's first revert cleanly.
Change-Id: I9eb567bda59e3ad88ddfa370d04d5d8e1f944aab
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191741
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Jenkins
(cherry picked from commit a2ed9aa09ad8d2601cf6198c8cd8647c08f09c16)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191765
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-10-02 Balazs Varga <balazs.varga@collabora.com> [83f80f46bfec8e023727db2d87c22876a2ddf6bd]
tdf#168589 - sc fix xls import with subtotal function
Check if the trimmed data range of Subtotal double references
is valid otherwise do not trim.
regression after: b89047a0f0100fb30121084cf42815aa792c1f88
(tdf#164843 - sc optimize "SubTotal" function's reference ranges)
Change-Id: I5f1fa4f67a685deb4a391e19e3acd9849b03c1b4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191691
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga@collabora.com>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191760
2025-10-01 Xisco Fauli <xiscofauli@libreoffice.org> [58f7ecbcf486672bc5c1dddd25cd0097113a8d51]
update credits
Change-Id: Ice1c1887ada55c21b7a9d1af86bb5315a3f7f70a
(cherry picked from commit a1911bbebc9fbd949f81755cb7148d53e13948ed)
2025-10-01 Jean-Pierre Ledure <jp@ledure.be> [1c81dbad870c2befad699e14e3694d684cf3064d]
ScriptForge fix tdf#168409 AccessibleContext
Extract from above bug report:
The accessibility UNO API is unpublished and
for LibreOffice-internal use only and
subject to change by design.
The com.sub.star.accessibility.AccessibleContext
service is used in ScriptForge to determine
the location on the screen, in pixels, of
next window subsets:
(1) a Calc cell or cellrange
=> calc.XRectangle(range) property
(2) a toolbarbutton in a docked toolbar
=> toolbar.ToolbarButtons(buttonname) method
In both situations, SF offers a facility
to display a well-positioned popup menu
triggered by a mouse left- or right-click.
The situation of the API is as follows:
- fully available in 25.2
- partially available in 25.8
(1) is not broken
(2) is broken
- fully vanished in 26.2
The gradual phase-out of the API requires,
to fix the bug, a tiered adaptation of
the code.
The choice is made to incorporate, where
appropriate, a switch to the right code
snippet based on the run LibreOffice version:
25.2, 25.8 or 26.2.
Now the behaviours in 25.2 and 25.8 are
identical. In 26.2, a different location
is returned for undocked toolbars.
The solution used for 26.2 must be considered
as still subject to change.
The emergency is to fix the issue in 25.8,
which is currently broken.
With the actual patch, the compatibility
between releases is restored, both in
Basic and Pythonuser scripts, and does
not need any documentation revision.
Change-Id: I29b4ccca3f11eca39e5a1841d3cfd744d5eb1fe3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191670
Tested-by: Jenkins
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191708
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-10-01 Xisco Fauli <xiscofauli@libreoffice.org> [a7f25c21ecb29817343a253866479adb93c57970]
Update git submodules
* Update translations from branch 'libreoffice-25-8'
to beabc8d706ba792b668024e5ba652feed42c5b28
- update translations for 25.8.2 rc2
and force-fix errors using pocheck
Change-Id: I388f345814db612a19ae52c95614e9a2c12de901
2025-10-01 Jim Raykowski <raykowj@gmail.com> [dd72fd35bbe35798026f2f22189e34e57cf6d65c]
tdf#167405 Fix outline folding crash
In this case one that happens on folding outline content when the
document view is set to 'Web' and the Navigator is open.
SwDocShell::Broadcast(SfxHint(SfxHintId::DocChanged)) in
SwRootFrame::CheckViewLayout causes an update of the Navigator content
tracking which when SwWrtShell::GetContentAtPos is called in
SwContentTree::Update eventually fails an assert in
objectpositioning::SwEnvironmentOfAnchoredObject::GetVertEnvironmentLayoutFrame
with the assert message:
"SwEnvironmentOfAnchoredObject::GetVertEnvironmentLayoutFrame(..) -
found frame isn't a layout frame"
stack at crash:
objectpositioning::SwEnvironmentOfAnchoredObject::GetVertEnvironmentLayoutFrame
environmentofanchoredobject.cxx 91
objectpositioning::SwToContentAnchoredObjectPosition::CalcPosition
tocntntanchoredobjectposition.cxx 287
SwFlyAtContentFrame::MakeObjPosfly cnt.cxx 1522
SwFlyFreeFrame::MakeAll flylay.cxx 222
SwFlyAtContentFrame::MakeAll flycnt.cxx 413
SwFrame::PrepareMake calcmove.cxx 396
SwFrame::Calc trvlfrm.cxx 1858
SwFlyFrame::Calc fly.cxx 3438
SwFlyFrame::GetModelPositionForViewPoint trvlfrm.cxx 567
(anonymous namespace)::lcl_GetModelPositionForViewPoint_Objects
trvlfrm.cxx 87
SwPageFrame::GetModelPositionForViewPoint trvlfrm.cxx 208
SwRootFrame::GetModelPositionForViewPoint trvlfrm.cxx 477
SwCursorShell::GetContentAtPos crstrvl.cxx 1519
SwContentTree::UpdateTracking content.cxx 4779
SwContentTree::TimerUpdate content.cxx 4668
SwContentTree::Notify content.cxx 4046
SfxBroadcaster::Broadcast SfxBroadcaster.cxx 43
SwRootFrame::CheckViewLayout pagechg.cxx 2515
SwFrame::AdjustNeighbourhood wsfrm.cxx 1816
SwLayoutFrame::ShrinkFrame wsfrm.cxx 3020
SwFrame::Shrink wsfrm.cxx 1635
SwContentFrame::Cut wsfrm.cxx 1390
SwContentNode::DelFrames node.cxx 1552
SwWrtShell::MakeOutlineContentVisible wrtsh1.cxx 2649
SwWrtShell::InvalidateOutlineContentVisibility wrtsh1.cxx 2703
SwEditWin::ToggleOutlineContentVisibility edtwin.cxx 7135
Fixed by waiting to paint until after removal of content frames during
InvalidateOutlineContentVisibility.
Change-Id: I69fdf173763211f42c5079069e79253ccdc19d79
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191576
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
Tested-by: Jenkins
(cherry picked from commit c2ad58945c22bf7c8e77c70fc66af1faf998ac54)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191705
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-10-01 Patrick Luby <guibmacdev@gmail.com> [078f04ac171034e42003b219b41a7522093ec4f5]
tdf#168609 catch exceptions from SwXText::getString()
Apparently, implementions of XTextRange::getString()
such as SwXText::getString() can throw an exception.
Change-Id: Ie23651bbc36466ec95a037142f760dd59c7d6417
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191645
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
Tested-by: Jenkins
(cherry picked from commit b86c16870251877962e986ec9d1418e1f376241f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191695
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-09-30 Jim Raykowski <raykowj@gmail.com> [63765c15a10cf41123c31b917d7aa9358405456b]
tdf#168560 Sidebar Find: Select text on keyboard focus in find entry box
Like with the find entry box in the F&R dialog there is a bit of glitch
when using gtk VCL when the find text is not selected and is click on it
becomes selected and then not selected.
Change-Id: I879f85b676d737d03c4bb02069f5d80f385d343d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191600
Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
(cherry picked from commit 4f33bb0f672a450ee5f2a4fd502398f2008fd7a8)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191650
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-09-30 Pranam Lashkari <lpranam@collabora.com> [7e9ef9557da52b219e2c7ce500345510f9cbbc9c]
tdf#156263: fixes freeze after opening data validity dialog
after making dialog async ScValidationRegisteredDlg was destroyed while
dialog is still running causing undefined behaviour
regression caused by 63b26e8e20f6a4eeb3117925b7a727f565e3a2dc
Change-Id: Idef30f12b88c46cb30a01ffb12588bb11e279750
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191105
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191116
Tested-by: Jenkins
(cherry picked from commit ef7151c271d14f623759f87d30e452f2e6d66664)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191652
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2025-09-30 Mike Kaganski <mike.kaganski@collabora.com> [665379874b65e963b8ebc39623dc25ffe5510a3c]
tdf#96787 tdf#168603 Skip primary language list, when country-specific found
... but don't skip the [All] (LANGUAGE_UNDETERMINED) list. See bug 141773
and commits ae56dc05b27f05ffcee99845d661a237e70a7a51 (tdf#96787: AutoCorrect:
after deleting a replacement entry, it's still used, 2021-01-10) and
50be3fa1f0f3b8870af5bda88b65f835ef37d77e (tdf#141773 AutoCorrect: fix broken
[All] dictionaries, 2024-06-29).
A separate issue is that the languags list in autocorrect options now lists
[Multiple] and [Undetermined], which shouldn't be there (the latter is the
same as [All]). It needs an own bug and a separate fix.
Change-Id: I1de8879c892efec23ce976b9e450088a22fdd652
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191643
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit a25c152abb31db437eb306f358ae71ab73d2e6ba)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191651
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-09-29 Aron Budea <aron.budea@collabora.com> [bd61271f10181fe6540264273753551779d4ac8a]
tdf#168598 Fix for tdf#148578 should only apply to RTF
It also affected DOCX files witch compatibilityMode
not specified.
Regression from 788cc6ff3b186ceb8f265e53b5482f808f6536f4
Change-Id: I1368066800ce4e6f4caa1131b1b6cf3590d8b1c1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191587
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Reviewed-by: Aron Budea <aron.budea@collabora.com>
(cherry picked from commit a80d7ba9c01c8c5c95bf01960d969b82dc7edffc)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191625
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-09-29 Jim Raykowski <raykowj@gmail.com> [6157d6838a8af0d24658ba5d62192a72a6e0edfe]
Assure folded outline button does not remain after outline
level direct formatting is cleared
Without this patch the fold button remains and a crash occurs if the
button is pressed. The patch also assures folded outline content is
shown for outlines set by a style after the RES_PARATR_GRABBAG
"OutlineContentVisibleAttr" is reset.
Change-Id: I5ee19ec972c3084f3ba64c11bda32932141c81f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191526
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
(cherry picked from commit 7ceb7a58e1bb1aca85435ded158fa2e19c004bf7)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191618
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-09-29 Dan Williams <dan@ioncontrol.co> [c7958ac67987a0418a0401fd51f10a8b3ea114f5]
connectivity/macab: avoid errors due to missing contacts.notes entitlement
Accessing an address book contact's Note field requires an entitlement since
Mac OS 13. Without that entitlement the following error occurs:
CoreData: error: Unhandled error occurred during faulting: Error Domain=NSCocoaErrorDomain Code=134092 "(null)"
It seems unlikely that the Note field functionality is widely used for
anything the address book functionality is used for, so just ignore the
field entirely.
Signed-off-by: Dan Williams <dan@ioncontrol.co>
Change-Id: I694f3ac40a8dccb49f51818dcdb3da7948f560d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191057
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
Tested-by: Jenkins
(cherry picked from commit 15ee3a463768810b438d558533a3baca0700d690)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191290
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-09-29 Khaled Hosny <khaled@aliftype.com> [f1e35b8ffd498b2d390f50ae9816fe0d9c904a49]
tdf#168371: Disable ligatures in Impress/Draw with character spacing
This is follow up to commit:
commit b9f0caad5d9e628f82d5148dfc7d2436d32817e2
Author: Khaled Hosny <khaled@aliftype.com>
Date: Tue Aug 23 04:13:28 2022 +0200
tdf#66819: Disable ligatures with character spacing
Even though editengine was applying letter spacing, when drawing with
drawinglayer, letter spacing was not propagated which caused VCL to not
disable the ligature features.
Change-Id: Ia8bf2231478720262484a757e16fe5afec3cd28e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191512
Reviewed-by: Khaled Hosny <khaled@libreoffice.org>
Tested-by: Jenkins
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191627
2025-09-29 Miklos Vajna <vmiklos@collabora.com> [92cc08867f025cd62419f92e26a4d717575ac116]
tdf#166338 vcl: avoid unwanted downscale in DrawTransformedBitmapEx()
Open the Impress bugdoc, the "Annotated result:" image's "red cable"
bitmap is sharp in edit mode, but is blurry when presenting.
This went wrong in commit 7c94d7267bc8b5f43185204ab4953c4b188214bf
(tdf#149943 vcl: fix pixelated PDF export and print for a rotated image,
2022-08-03), which stopped changing the scale part of the transform
matrix. The old problem was that the transform resulted in a downscale:
debug:5739:5739: OutputDevice::DrawTransformedBitmapEx: aOriginalScale w,h is 226,100, aFullScale is (906.698,6277.69) -> for w, we go from 906 to 226
The new use-case is that this transform used to upscale in the past,
which preserved more pixels from the original bitmap:
debug:5632:5632: OutputDevice::DrawTransformedBitmapEx: aOriginalScale w,h is 326,1125, aFullScale is (21.1276,76.1197) -> for w, we go from 21 to 326
Fix the problem by conditionally restore the change of the scale in the
transform matrix: only do it when we would upscale. This was the
presented bitmap is sharp again, but the old use-case continues to work.
The deeper problem is why slideshow goes via a metafile at all, but
that's not changed here.
Change-Id: I73ef426dc9d047a0231a700b0fe7ed0e4747d81b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191497
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit e81b948f90e66779e225d0dfb5e3ad1e6e80f289)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191599
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-09-29 Balazs Varga <balazs.varga@collabora.com> [161311deff7d1efaa7cca1f06b74df4d1b5f7efb]
tdf#140866 - sc fix cell comments disappear after ods saving
They disappeared because before saving the file to ods
some other drawing objects very copied and pasted on the sheet
which caused a recalculation of all the cell anchored drawing object's
anchor position with SetCellAnchoredFromPosition since commit:
545737df40880875304bffc3f49800d1d2e99723
No need to recalculate the cell anchor position of Caption objects
since their anchor position is handled differently.
Change-Id: I83d54075974d9a7c2676af23f285e621afe0d523
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191548
Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de>
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga@collabora.com>
(cherry picked from commit d932a383766b6133ffe9ebf077f95cc328807b1b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191608
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-09-29 Mike Kaganski <mike.kaganski@collabora.com> [ecb65b032dc169cda9e5beed2d2a61ab47619bdb]
tdf#168599: don't create Any from a direct reference to an interface
An overlook from commit 3cb0678a9cac9a681903b5a082d1c5dd5f25f665
(fix dodgy DrawController::fireChangeLayer code, 2025-03-05).
This goes through this ctor:
template <typename T>
inline Any::Any( T const & value )
{
::uno_type_any_construct(
this, const_cast<T *>(&value),
::cppu::getTypeFavourUnsigned(&value).getTypeLibType(),
cpp_acquire );
}
which gets a valid type for the value (typelib_TypeClass_INTERFACE),
and then uses a raw pointer in uno_type_any_construct. This crashes
(0xC0000005: Access violation reading location 0xFFFFFFFFFFFFFFFF)
because _copyConstructAnyFromData assumes typelib_TypeClass_INTERFACE
case to have a pointer to pointer (a pointer to css::uno::Reference,
which is itseld a lone pointer), with this stack:
sdlo.dll!com::sun::star::uno::cpp_acquire(void * pCppI) Line 47
cppu3.dll!cppu::_acquire(void * p, void(*)(void *) acquire) Line 70
cppu3.dll!cppu::_copyConstructAnyFromData(_uno_Any * pDestAny, void * pSource, _typelib_TypeDescriptionReference * pType, _typelib_TypeDescription * pTypeDescr, void(*)(void *) acquire, _uno_Mapping * mapping) Line 243
cppu3.dll!cppu::_copyConstructAny(_uno_Any * pDestAny, void * pSource, _typelib_TypeDescriptionReference * pType, _typelib_TypeDescription * pTypeDescr, void(*)(void *) acquire, _uno_Mapping * mapping) Line 284
cppu3.dll!uno_type_any_construct(_uno_Any * pDest, void * pSource, _typelib_TypeDescriptionReference * pType, void(*)(void *) acquire) Line 69
sdlo.dll!com::sun::star::uno::Any::Any<com::sun::star::drawing::XLayer>(const com::sun::star::drawing::XLayer & value) Line 68
sdlo.dll!sd::DrawController::fireChangeLayer(const com::sun::star::uno::Reference<com::sun::star::drawing::XLayer> & xNewLayer) Line 473
sdlo.dll!sd::DrawViewShell::SetActiveTabLayerIndex(int nIndex) Line 635
sdlo.dll!sd::FuPoor::SwitchLayer(long nOffset) Line 1060
sdlo.dll!sd::FuPoor::KeyInput(const KeyEvent & rKEvt) Line 493
sdlo.dll!sd::FuDraw::KeyInput(const KeyEvent & rKEvt) Line 432
sdlo.dll!sd::FuSelection::KeyInput(const KeyEvent & rKEvt) Line 1056
sdlo.dll!sd::ViewShell::KeyInput(const KeyEvent & rKEvt, sd::Window * pWin) Line 530
sdlo.dll!sd::DrawViewShell::KeyInput(const KeyEvent & rKEvt, sd::Window * pWin) Line 252
sdlo.dll!sd::Window::KeyInput(const KeyEvent & rKEvt) Line 226
vcllo.dll!ImplHandleKey(vcl::Window * pWindow, NotifyEventType nSVEvent, unsigned short nKeyCode, unsigned short nCharCode, unsigned short nRepeat, bool bForward) Line 1236
vcllo.dll!ImplWindowFrameProc(vcl::Window * _pWindow, SalEvent nEvent, const void * pEvent) Line 2742
vcllo.dll!SalFrame::CallCallback(SalEvent nEvent, const void * pEvent) Line 310
vclplug_winlo.dll!ImplHandleKeyMsg(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, __int64 & rResult) Line 4011
vclplug_winlo.dll!SalFrameWndProc(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam, bool & rDef) Line 5925
vclplug_winlo.dll!SalFrameWndProcW(HWND__ * hWnd, unsigned int nMsg, unsigned __int64 wParam, __int64 lParam) Line 6226
user32.dll!UserCallWinProcCheckWow(struct _ACTIVATION_CONTEXT *,__int64 (*)(struct tagWND *,unsigned int,unsigned __int64,__int64),struct HWND__ *,enum _WM_VALUE,unsigned __int64,__int64,void *,int)
user32.dll!CallWindowProcW()
opengl32.dll!wglWndProc()
user32.dll!UserCallWinProcCheckWow(struct _ACTIVATION_CONTEXT *,__int64 (*)(struct tagWND *,unsigned int,unsigned __int64,__int64),struct HWND__ *,enum _WM_VALUE,unsigned __int64,__int64,void *,int)
user32.dll!DispatchMessageWorker()
vclplug_winlo.dll!ImplSalDispatchMessage(const tagMSG * pMsg) Line 431
vclplug_winlo.dll!ImplSalYield(bool bWait, bool bHandleAllCurrentEvents) Line 500
vclplug_winlo.dll!WinSalInstance::DoYield(bool bWait, bool bHandleAllCurrentEvents) Line 537
vcllo.dll!ImplYield(bool i_bWait, bool i_bAllEvents) Line 389
vcllo.dll!Application::Yield() Line 492
vcllo.dll!Application::Execute() Line 365
sofficeapp.dll!desktop::Desktop::Main() Line 1682
vcllo.dll!ImplSVMain() Line 230
vcllo.dll!SVMain() Line 249
sofficeapp.dll!soffice_main() Line 122
soffice.bin!sal_main() Line 51
soffice.bin!main(int argc, char * * argv) Line 49
soffice.bin!invoke_main() Line 79
soffice.bin!__scrt_common_main_seh() Line 288
soffice.bin!__scrt_common_main() Line 331
soffice.bin!mainCRTStartup(void * __formal) Line 17
kernel32.dll!BaseThreadInitThunk()
ntdll.dll!RtlUserThreadStart()
Change-Id: Ib61823e74b260d262adbaa5d3d63232b599d3cac
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191593
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
(cherry picked from commit 16a0b42a4f79a20a2aaf8dd443c55b81a8084351)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191607
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-09-29 Oliver Specht <oliver.specht@cib.de> [fd25b527b3c03f20050aad763b8eb18982f018c0]
tdf#167973 Fixes case rotation in selection in multiple paragraphs
Broken in commit b1170251fbca5b6b243902cf10695ab4c4c5642b because it checked
the selection in a single paragraph only.
Change-Id: If84aca87c9fee5750751cd91cb08372714f17eba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191472
Tested-by: Jenkins
Reviewed-by: Oliver Specht <oliver.specht@cib.de>
(cherry picked from commit bb496f5494a23c247c86fdf5ae65054908df44ce)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191601
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-09-29 Mike Kaganski <mike.kaganski@collabora.com> [3d7003a7c1010ba50cb6442f407d2560d9aaf26a]
tdf#168569: support date values in string pool
Commit f45463d8e2bb0771ec1837d159ff98108b0047cf (tdf#93727 Support date
literals in basic, 2017-05-24) introduced correct parsing of literals
like #2025-09-26#. However, it didn't retain the value type; there was
a discussion about that in gerrit, but no solution was found, and type
was set to double.
Later, a similar problem (storing type of value in compiled image) was
fixed in commit 5eedb3beeaeed88de0d1ebd041a9f15ceea7e78c (tdf#142460:
properly handle boolean values in string pool, 2021-06-25).
This change reuses the same method to store date type using 'd' char in
the string pool.
Change-Id: I32e8497ece1f30980ba6d4fca248687b817348f2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191555
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 22d7827c6695358e11ee06a5599b72a92ff0b2ac)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191595
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-09-29 Mike Kaganski <mike.kaganski@collabora.com> [f846899e0b6fc2ec9ab2b4a4f65d06549e3f0763]
tdf#168561: fix Str function implementation
1. If a string is passed as argument, it is returned without any changes.
For that, SbRtl_Str checks argument type, skipping processing for string.
2. Non-negative numbers are preceded by a blank space.
That already was implemented.
3. Negative numbers are preceded by a minus sign.
That was done incorrectly - a space was added for any number.
4. Dates are converted into locale-dependent strings.
That wasn't done at all - dates were converted to strings representing
the serial date. A check is implemented SbxValue::Format, to handle this.
Additionally, Format function was improved to handle such input without
format string (taking into account that it handles strings that can be
converted to numbers differently).
Change-Id: I5ac0429950e4ea8bf69b0091502b4e6dc1f4957d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191549
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
(cherry picked from commit 92878d3216aeaf0e5131c0c3fa1f8dc9ce67b5b4)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191582
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-09-27 Noel Grandin <noel.grandin@collabora.co.uk> [5442778d975c1a6146ce6ff0c66a13c64dcab904]
tdf#166895 Document Colors do not appear anymore in the color selection
missed a spot where we are using surrogate functionality.
Also rename ForEachCharacterBrushItem->ForEachCharacterBackgroundBrushItem to make it more obvious.
Regression from
commit 56d35ad0eaccd353c8acd2a259293199e233e8ec
Author: Noel Grandin <noelgrandin@gmail.com>
Date: Mon Sep 9 17:14:43 2024 +0200
RES_CHRATR_HIGHLIGHT does not need surrogate support
and
commit 08c58ac51962b65b57c5b76a45467d45807ef02d
Author: Noel Grandin <noelgrandin@gmail.com>
Date: Mon Sep 16 21:04:59 2024 +0200
dont use GetItemSurrogates for gathering SvxColorItem
and
commit b6a5cdc0f753c8ed6ed080f9189ac2e2601dce9d
Author: Noel Grandin <noelgrandin@gmail.com>
Date: Tue Sep 17 20:19:06 2024 +020
dont use GetItemSurrogates for gathering SvxBrushItem
Change-Id: Id67d78aa82f8731555f06b23760c4ea8f0d8eeb5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191317
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit 50099a54cd32afd361810e3059af3b420741d41b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191352
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-09-27 Jim Raykowski <raykowj@gmail.com> [758eebe416aa26e61a02fb491406ad225bf36e02]
tdf#168025 Fix style spotlight numbers in styles list do not always
match style spotlight numbers in document view
This is a partial revert of commit
b5e366c97d813c65d477941d45ae55f7dff954ad
Change-Id: I016f8039d9b8e228afe26231a565679320c1f726
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191373
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
(cherry picked from commit 3967cdfe862dd4d542ae50cf16c46a62ab17cfa0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191411
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-09-27 Laurent Balland <laurent.balland@mailo.fr> [a5dc5761eedf7dc8e33fc9cd2a0817c682c7270d]
tdf#168571 Restore gradient in Candy template
draw:fill-gradient-name requires draw:fill="gradient"
Change-Id: I3646b683486317e804adccb9faf994742fe1fb0c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191562
Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
Tested-by: Jenkins
(cherry picked from commit 771a93e3be34dfbd77b4dbba407caa9677090488)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191569
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-09-26 Xisco Fauli <xiscofauli@libreoffice.org> [5ab3bd933fa7c482ee7b3a970fa2013ea9b1fc9d]
liblangtag: upgrade to 0.6.8
0001-const-up-__lt_localealias_tables.patch.1 has been fixed
upstream
Downloaded from https://gitlab.com/-/project/74684761/uploads/9f74bd278e6edfbf1093605d38fb7a97/liblangtag-0.6.8.tar.bz2
Change-Id: I4b171d98271921c959115a8fabdf20217350be5d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191445
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
(cherry picked from commit 9bb3947fadb83712492a156b3477d82f2280a3b3)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191450
Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2025-09-26 Xisco Fauli <xiscofauli@libreoffice.org> [1522ce4e0f929c77d7ae26868a2e7c482e276926]
harfbuzz: upgrade to 11.5.1
Downloaded from https://github.com/harfbuzz/harfbuzz/releases/download/11.5.1/harfbuzz-11.5.1.tar.xz
Change-Id: I714b790bb241a48d6ffcf81fbf23853221530d7c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191382
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
(cherry picked from commit 122ca4944587c485889fc1680dab43949f4d9dce)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191389
Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2025-09-26 Xisco Fauli <xiscofauli@libreoffice.org> [fe4196a5858282e0059e8f5e31c71f22899520d9]
libetonyek: upgrade to 0.1.13
Generated with:
./autogen.sh
./configure
make dist-xz
Change-Id: I29556afa131f622652b4fbc5b46e0c3c0e5b1bee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191333
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
(cherry picked from commit 7290daa1e12c5e81ed8c2909cdb6a164bfb3c478)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191351
Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2025-09-26 Xisco Fauli <xiscofauli@libreoffice.org> [3d076e078e1f6f1a5899eb9f442fbcec5c762bcb]
libvisio: upgrade to 0.1.10
Generated with:
./autogen.sh
./configure
make dist-xz
Change-Id: Ida45f447bdd49bf4ee600e0f24a7bf4eb5cb0bca
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191403
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
(cherry picked from commit 63887d9aaa252ee1b1b066831b28b53867a8c67f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191412
Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2025-09-26 Xisco Fauli <xiscofauli@libreoffice.org> [bd246c04e4245aa2a75700dd1687e75746d6deb3]
tiff: upgrade to 4.7.1
Downloaded from https://download.osgeo.org/libtiff/tiff-4.7.1.tar.xz
Change-Id: I9eda3018e55e771986968ffacf7081538baf432b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191142
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
(cherry picked from commit b3a027d2b7273478773bd0d8624b70f9a48b0952)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191162
Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2025-09-26 Xisco Fauli <xiscofauli@libreoffice.org> [73a58ecd58ebe3a7275bb99eb19fd82113d0237f]
expat: upgrade to 2.7.3
Downloaded from https://github.com/libexpat/libexpat/releases/download/R_2_7_3/expat-2.7.3.tar.xz
Change-Id: I2141a3d2881e693867b23ca56a1d6a929f17c4fe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191481
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
(cherry picked from commit 3bceab5b951aa45bc7ab1d86ebcfda8981d9693f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191496
Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2025-09-25 Jim Raykowski <raykowj@gmail.com> [5b9e275838ec1cd08f1c1755de545b4f7f34c7d1]
tdf#166713 Fix crash in lcl_FoldedOutlineNodeEndOfParaSplit
by handling the case of a paragraph outline level set by direct
formatting.
Change-Id: Ida0c8f91f0fb0584b39c16b3ddf2201429c6943f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191471
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
(cherry picked from commit fd9ae53e39f3219474461d1e8e3220d8efdfcecb)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191482
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-09-25 Mike Kaganski <mike.kaganski@collabora.com> [8566b6167c5f788bf5849a461e4a52f66b6e3682]
tdf#168533: make sure to emit frame properties, when they changed
... because of popping state.
In the RTF markup:
\pard\pvpara\phpara\posx3500\posy0\absw3800\wraparound
Frame 2\par
{\pard Still frame 2}\par
the frame is created first: the frame properties are collected, m_bNeedPap
is set to true, and the frame settings are pushed in checkNeedPap, called
from RTFDocumentImpl::text() when "Frame 2" text arrives; that resets
m_bNeedPap. When checkNeedPap is called from \par handler code, m_bNeedPap
is false, and it bails out.
Then opening brace creates a new state on the stack; \pard resets all the
paragraph properties to default, including frame properties; then text
"Still frame 2" arrives, calling checkNeedPap, which doesn't send frame
properties, because there's none at this moment; it resets m_bNeedPap.
Then closing brace pops the state from stack, returning to the state with
the frame properties; and \par handler in RTFDocumentImpl::dispatchSymbol
calls checkNeedPap. But at this point, m_bNeedPap was still false, so it
bailed out, and didn't send the frame properties - so in the end, the
current paragraph never obtained frame properties, and got imported into
the main text flow.
This change makes sure, that whenever popping the state changes the frame
properties, m_bNeedPap is set, to ensure emitting it when time comes.
Change-Id: I61b95e2818a66f54d7026db3cbb85e92135807c9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191439
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 202d41e0fb2432ca286953d5f7464289fcb52e30)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191453
Reviewed-by: Thorsten Behrens <thorsten.behrens@collabora.com>
2025-09-25 Xisco Fauli <xiscofauli@libreoffice.org> [6061ce779980d538c5c844cb5a9421e659e48536]
lxml: upgrade to 6.0.2
Downloaded from https://github.com/lxml/lxml/releases/download/lxml-6.0.2/lxml-6.0.2.tar.gz
Change-Id: If3a32f2c34fe7742ce83fdb8051616c97b9674f7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191311
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 0453e8493e96c006a45a0accda26251531fd0eed)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191328
Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2025-09-24 Balazs Varga <balazs.varga@collabora.com> [3e528101c3593eedaea492d03831630b03e933dd]
tdf#167042 - sc cell comments texts should not be deleted
but the note text should be remembered in maNoteData to be able
to later reconstruct a caption from it.
Originally the bPreserveData was introduced and set to true in commit:
b8b657123cc508c906622d20669507628c93e104
(tdf#104967 preserve isolated notes data in clipboard when closing document)
The original bugdoc from tdf#104967 was checked with this patch and
had no crash with it.
Change-Id: I3b6c56e4828c11c2cab0351c95dd4bcb5762d86e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191396
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga@collabora.com>
(cherry picked from commit 01765ffe843953bbf7d1e2822512306d3776b3be)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191461
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-09-24 Andreas Heinisch <andreas.heinisch@yahoo.de> [79b1860c23ead30dd230768012db72075f4c11f5]
tdf#168478 - Use the previously found range rather than returning an empty one
During the reset of a standard filter, if the correct boundaries are not
selected, do not return an empty range. Instead, reuse the previously
found range at the selection.
Change-Id: I42a603a8a284036710b608a519abd781b90991e1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191245
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 6f68c46d0aa5fe872de0dec8777d35ff91886043)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191421
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-09-23 Xisco Fauli <xiscofauli@libreoffice.org> [fa88c843765ba5562010018241727b43a3d338eb]
libvisio: upgrade to 0.1.9
Generated with:
./autogen.sh
./configure
make dist-xz
Change-Id: I7b588ca176024055486f41ddcec1394f5971f97e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191320
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 1ac9e00df08f52c884a858180a0b1c14788ad4b3)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191334
2025-09-23 Balazs Varga <balazs.varga@collabora.com> [465f423e4995c8ecb1e981db16d2c6b7c11c28ba]
tdf#168422 - Fix SUMPRODUCT calculation is broken in some cases
Double refs with operators only trimmable in case of one root paramater.
Follow up of: 969ddf72824942be9755a8d14482d6549a2231ce
regression after commit: 969ddf72824942be9755a8d14482d6549a2231ce
Change-Id: I87365efc5b7bc54bfdda4d33e4b5b9550d6e2602
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191365
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga@collabora.com>
(cherry picked from commit 22c0eb18f5dcaa76d4fc7a65e98e1d20589ced04)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191379
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-09-22 Laurent Balland <laurent.balland@mailo.fr> [d1e0f1ca1d9bbb810018df753f9529d3044c2f59]
tdf#168444 Fix XML in content.xml
<office:text> tag is not present in other languages
removing it fix the bug
Change-Id: I2aeae0ba5d254f2b271557369c2d1faf3204c2c0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191244
Tested-by: Jenkins
Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191324
2025-09-22 Laurent Balland <laurent.balland@mailo.fr> [8b83439dc0cc270a1eb517d3efb652293f1fbce8]
Indentation of XML files in AutoText
apply xmllint -- format to all XML files
This will ease debugging of XML, like tdf#168444
Change-Id: Iacb79990e49236e13490524f77460ebb0fec1653
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191241
Tested-by: Jenkins
Reviewed-by: Laurent Balland <laurent.balland@mailo.fr>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191323
2025-09-21 Patrick Luby <guibmacdev@gmail.com> [2dc604d5dc088dd80c8254bf5e2bddd5acac3bf7]
tdf#168375 return false if both KEY_MOD1 and KEY_MOD2 are pressed
Previously ImpEditEngine::IsSimpleCharInput() returned false only
if one of these modifiers is pressed. At least on macOS, pressing
Command-Option with a character is not a simple character so return
false if both modifiers are pressed.
Change-Id: I7698a1ec3178b83c0a1d4e161915246cac08f0ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191205
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit ed45cdaef3d2807d0b9d6a4c08da375fc72024a6)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191209
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-09-21 Justin Luth <jluth@mail.com> [a6091a34e6adcd5780564f55abba40ffd279faa9]
tdf#166406 sw nbb: position LTR and RTL side by side
The worst thing to do to a bug
is to mark it as an easy hack.
That just means it will never be solved.
With the increased push to spotlight the NBB,
these papercuts should be solved ASAP
instead of languishing forever.
Change-Id: I8e5736add29b7db26ada0d671bc00b86d1c45fae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191208
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
(cherry picked from commit 369b726d308270679b792aa21c92bd0b308ec171)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191217
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-09-20 Jean-Pierre Ledure <jp@ledure.be> [445d1ece2922bd6cf278b35c62cef9bb51879417]
ScriptForge fix tdf#168433 array.ImportFromCSVFile
The import of a CSV-formatted file
into an array fails when specific
combinations of double quotes and
commas (= delimiter) are present.
The
array.ImportFromCSVFile()
method uses internally the
string.SplitNotQuoted()
method for parsing the input
records.
The latter method skips the delimiters
located inside quoted strings.
It was buggy and needed a revision.
Documentation unchanged.
Change-Id: Ie156455b99749c6a8e4f43f4d3c258772904848f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191227
Tested-by: Jenkins
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
(cherry picked from commit cf57cf042aaa863ff6a730e79df1df1a5dbefc9e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191229
2025-09-20 Xisco Fauli <xiscofauli@libreoffice.org> [e5f0dad2b38d2a3902a9cd6b9d434abc206590a4]
tdf#168452: support unicode-bidi in svg
Before this change, getBiDiStrong() was never used
to manipulate the text
Change-Id: I9d6a2e8b79d27126902f2be84174c641ec71c28c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191123
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit f127f708f6ccc941beabaacc7be18daf478a79cd)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191133
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-09-20 Caolán McNamara <caolan.mcnamara@collabora.com> [1c9a034783686f5b4bcbd29b4025d0a43d9a5c83]
Resolves: tdf#156739 implement dnd for menu/toolbar customization pages
dubious as a regression, but can be done now regardless
Change-Id: I67bc322cd63e65b5347b3e54651e3618d09a99b6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190917
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
(cherry picked from commit f4e2563012ff091ee27999713063fc87cd01fe7e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190958
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-09-19 Noel Grandin <noelgrandin@gmail.com> [d3def5d2894170c5832418b5008896c5ad3b82bf]
tdf#166483 special char dialog not available with mergedlibs build
Change-Id: I08cc1fe82845cfea82150e332b0ea0ad597f6cda
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191189
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit 9f4304ff2dbb706a1160afd347e538e615e1290f)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191191
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-09-19 Mike Kaganski <mike.kaganski@collabora.com> [1c78cb0673e117136212fea7b51adcf898ff94f5]
tdf#168431: Release solar mutex when sending window message to main thread
It started after commit 1e2e51607a163021ef1fb1fb0d217266bd448173 for some
reason, but the problem is, that the caller code from some thread holds
the solar mutex, and the code that handles the message in main VCL thread
tries to lock solar mutex; and that didn't change.
This change introduces some methods in WinSalInstance, that wrap calls to
SendMessageW, and release solar mutex if the functions are not in the main
thread.
Change-Id: Iac8690acbd306273c92534c6d319cbdf4b799860
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191147
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191183
2025-09-19 Noel Grandin <noelgrandin@gmail.com> [7be45c419d98c4b68bdf359adedd3be6aafc2fcf]
inline Init/ReleaseFrameGraphicsDC
which makes it much more obvious which logic belongs where.
Which fixes leaking WinSalGraphics objects on on error paths.
Change-Id: Ib08c5b365e993d46fdc38a56e20e12c2833a1f85
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187851
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191182
2025-09-19 Noel Grandin <noelgrandin@gmail.com> [2a93939b3535c6790eb475aab436a188ca294d01]
remove mnCacheDCInUse
Windows95 has not been supported for some time, we don't need this
limitation anymore.
Change-Id: I52a476bb1da4db8fc8e7a420f049c3f895549fa1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187891
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191181
2025-09-18 Noel Grandin <noel.grandin@collabora.co.uk> [ef0fd8bfab009f939432eb7f24bc6604dcc90caf]
tdf#168344, tdf#166842 do not use FillColor==COL_TRANSPARENT...
.. on OutputDevice if that OutputDevice does not support alpha
Change-Id: I52f8a496127462deecba9cf6fd19f827466d16cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/187181
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
(cherry picked from commit 878dd795378776253e6c49d58805a219e0b8c33e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191135
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-09-18 Miklos Vajna <vmiklos@collabora.com> [1f6b2a4d6db61f0ae0f00774b3104cf679c3db4d]
tdf#168325 sw format redline, char style: improve recording
Create a new Writer document with a single word in it, set the Emphasis character
style on it, enable redline record, change char style to Strong
Emphasis, save to ODT. The format redline refers to an automatic style,
while it should refer to the old char style (Emphasis).
This happens because the redline record for format redline works
incorrectly: it not only records the char style (before changing the
char style), but also the expanded value of the char style, which leads
to the creation of an automatic style on ODT export. This doesn't happen
if exporting an originally DOCX file to ODT.
Fix the problem by explicitly asking for the current character
properties in a way so that char styles are not expanded, when making a
copy of the old formatting & storing it in a format redline.
Also drop storing RSIDs in format redlines, they are not interesting and
again would lead to unwanted creation of automatic styles.
Change-Id: Idd34afb1f0570589254a9eb259af4fc3465aec22
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191120
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
(cherry picked from commit 0c7eaa023a840a6f0967fe119463a936241a8130)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191138
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-09-18 Justin Luth <jluth@mail.com> [d24e8a20907bf3e861dad93456d0dea891c3b320]
tdf#168377 sw: avoid crash in redlndlg - index out of range
Everywhere else GetRedlinePos() is used
it is checked against SwRedlineTable::npos
to identify a valid index position.
Change-Id: I46a52a9c7aadab4b1690562c0ba32027cd2dcd2f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191121
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
(cherry picked from commit c920581dc81e553a07d0cd27f5d218df39811b6d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191137
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-09-18 Heiko Tietze <heiko.tietze@documentfoundation.org> [78373e24f4144df9c28e485e89dc86144752719c]
Resolves tdf#168259 - Add "Show Again" checkbox to SaveAs query
This backport also includes the follow-up commit
Resolves tdf#168259 - Hide "Show Again" if readonly
Change-Id: I60b034d43bfe7069319b6dc70b0b9e00cc5e1e45
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190553
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191158
Reviewed-by: Justin Luth <jluth@mail.com>
2025-09-18 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [6cc399f63684da0967bd95f9678447110c00f15a]
bump product version to 25.8.3.0.0+
Change-Id: Iebaee6564dde714612e124d06c24225cf87f9384
2025-09-18 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [c316dc790dc64dfd5d82774dd1f66574219bfaed]
Update git submodules
* Update translations from branch 'libreoffice-25-8'
to 234344c9b22893272b6be8e30e6fb556a6d9e664
- update translations for 25.8.2 rc1
and force-fix errors using pocheck
Change-Id: Ia769c987fe3a86ccccf9c46be051dcae1a1221e2
2025-09-17 Julien Nabet <serval2412@yahoo.fr> [cb8bf48260a43895cbb5b1c51e13ce9cdf53e69b]
Related tdf#168265: ignore more comments line
1) since 999 indicates a comment section, call DXFSkipLine in case of 999
2) let's consider the case the beginning contains more than 1 comment
Limit: we only sniff 256 bytes to detect the format so if comments are too long
detection won't work
Change-Id: I11a01db49d3faad68c7ab134be0f716767583185
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190865
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
(cherry picked from commit 829f59de4e44a5a2c9888e7ceef439809808f2c0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190870
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-09-17 Patrick Luby <guibmacdev@gmail.com> [87f4a7b3838b6dc5bb740884b9e5132fb98e54f2]
Fix HarfBuzz build breakage when building on macOS Tahoe
Starting in Xcode 26, compiling with -D_LIBCPP_ENABLE_ASSERTIONS will
fail due to a change made by Apple.
HarfBuzz uses meson to define the macros needed to build HarfBuzz
and meson 1.7.2 and 1.8.0 still emit -D_LIBCPP_ENABLE_ASSERTIONS.
So upgrade the internal meson to 1.8.3 (i.e. the first version that
is compatible with Xcode 26) and use the internal meson if building
with Xcode 26 or higher and the external meson version is too old.
Change-Id: I0d3545b0b1a22156179fec1382260adca1e9221c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/188863
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Jenkins
(cherry picked from commit 26c44f98d0ab203090d5b634853ec1177b6d1977)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190770
2025-09-17 Jonathan Clark <jonathan@libreoffice.org> [2ef84ee2e6856b5a4729f0f59f8c02f2e1106e9d]
tdf#168424 editeng: Fix unsafe s/uint implicit cast in RTF parser
The editeng RTF parser was round-tripping signed integers through a
sal_uInt16 via implicit casts when populating SvxLRSpaceItem. This
worked because such an implicit cast may convert signed numbers into
their unsigned two's complement representation, and vice-versa.
Unfortunately, a recent change to SvxLRSpaceItem replaced the final
implicit uint-to-sint cast with an implicit uint-to-double one, which
does not have the same properties.
Change-Id: I80b1a36c47323309b33a8ddaee652c238a7530f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191052
Tested-by: Jenkins
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
(cherry picked from commit c93d70db199cc7f89490cf9f34aa43ea67892c52)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191100
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-09-17 Mike Kaganski <mike.kaganski@collabora.com> [72dbdf4f967770e790ab31cb1b22b70686c61993]
tdf#168423: Allow subnormals from strtod
dtoa sets ERANGE with subnormals. We need to support these, so check
for infinity and zero explicitly, and allow other results. NaNs can't
appear here.
Change-Id: I006a42ebff03b07d219b423c13bf8230348e1def
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191071
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit a3aaa11db039675252fe9d5bc4a9d43be34940e8)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191093
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-09-17 Dan Williams <dan@ioncontrol.co> [bc60c90e73b2e8d3c0bdfe6dad087ea5e51ac240]
connectivity/macab: use CoreFoundation instead of Carbon
The Mac address book connector doesn't actually use Carbon,
so just import/link to CoreFoundation.
Signed-off-by: Dan Williams <dan@ioncontrol.co>
Change-Id: I17f42ba6a9355d45ed5c7c60214cb50d803ffbc2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191051
Tested-by: Jenkins
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
(cherry picked from commit 4dc20af89779241eeae85f61b32a9b1d85c6da3e)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191094
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-09-17 Dan Williams <dan@ioncontrol.co> [dec1441f716c7631622b9b3e32fdbc666502c006]
vcl/sal: remove unecessary Mac OS includes and linkage to Carbon
A number of places that #include <Carbon/Carbon.h> don't actually
need it, but want CoreFoundation or other includes instead. We're
trying to get rid of Carbon so let's make it clearer what really
needs it still.
Change-Id: Ief60b4324dccd936aa7def3ea2c685c393f9050a
Signed-off-by: Dan Williams <dan@ioncontrol.co>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191030
Reviewed-by: Patrick Luby <guibomacdev@gmail.com>
Tested-by: Jenkins
(cherry picked from commit db3d15e46324ef4fcb9aee0b760f923f9a4fa231)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191098
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-09-17 Xisco Fauli <xiscofauli@libreoffice.org> [f374a9821b22e900ef6b05d652e4f2b0786b42dd]
harfbuzz: upgrade to 11.5.0
Downloaded from https://github.com/harfbuzz/harfbuzz/releases/download/11.5.0/harfbuzz-11.5.0.tar.xz
Change-Id: I73db5e0de6c78898a8cca957c203b6e5961271c4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190950
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit c301b1e14bd5854f12b6b8ad2bed5ff7dd1d5821)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190957
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-09-17 Xisco Fauli <xiscofauli@libreoffice.org> [48b650d50070cd1bff391aef53f781c16899d92d]
sd: use SAL_RET_MAYBENULL in GetSlideSorter
Change-Id: I2f71942aeaa7aa1cc78be69d63a94588099ad4d8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190821
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190877
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-09-17 Xisco Fauli <xiscofauli@libreoffice.org> [6b8479d71863b015d0d8bcbd292791f07857b2fa]
tdf#168363: check SlideSorterViewShell
After
commit 7dddd449068d69ec2f47bfca2487f01fa7067fd0
Author: Pranam Lashkari <lpranam@collabora.com>
Date: Tue Apr 15 21:19:43 2025 +0530
sd: copy slides from instance to another
Change-Id: I77a315981c0178144c985b29b4ebb733e42bd000
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190820
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit fd10eb45fdb95f2fc3386ef7ee1423279d764ac3)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190824
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-09-17 Xisco Fauli <xiscofauli@libreoffice.org> [9d3eb682d30c4e7e37bc844109746b711343f025]
mariadb-connector-c: upgrade to 3.3.17
c23.patch.0 has been fixed upstream
Downloaded from https://dlm.mariadb.com/4441363/Connectors/c/connector-c-3.3.17/mariadb-connector-c-3.3.17-src.tar.gz
Change-Id: Idf813aa383f22b8ae22ac92e23fc0ffa78050f38
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190795
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190808
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-09-17 Xisco Fauli <xiscofauli@libreoffice.org> [03a4361a7685ba2e104704c92ab09cc1b9cc648e]
curl: patch CVE-2025-9086 and CVE-2025-10148
More info in https://curl.se/docs/CVE-2025-9086.html
and https://curl.se/docs/CVE-2025-10148.html
Change-Id: Ib4993a00efdabf0baa3fe0e25c66d850f370572a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190741
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190751
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-09-17 Julien Nabet <serval2412@yahoo.fr> [fc1b29c610274e636f317e36e4d8d39b16c54185]
Update git submodules
* Update helpcontent2 from branch 'libreoffice-25-8'
to 5ea29a8c84b5c4607092f92bf4c97106e1e6e2d0
- tdf#167789: fix date format for COUPPCD result
Change-Id: I8a131751ad4e329834b3a97d30fbbf46c317e4cb
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/188871
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
(cherry picked from commit 7db5e16a2bd98ea0c1cd4d9cbe1a00cf715461a8)
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/190727
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-09-17 Xisco Fauli <xiscofauli@libreoffice.org> [38b6906b5cd044cfd6f4ef594848f0a1f9952ee1]
crashreport: avoid crash in InspectorTextPanel
define FN_HIGHLIGHT_CHAR_DF in sfx2 like the
other spotlight slots and rename it accordingly
Seen in https://crashreport.libreoffice.org/stats/crash_details/a6200006-147e-4829-9293-93de0487133b
Since
commit 0d0e5c72e6344de48227b74846a6ff638b803c64
Author: Karthik <me@karthikreddy.org>
Date: Mon Mar 10 13:34:39 2025 +0530
tdf#160194 Add 3 checkboxes in Style InspectorPanel
Change-Id: I108fcbf39c8f6879258c9804f7f5a15313d259ec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190684
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 6fc54eea2f904a6704495f6b53fd5eff0dff1496)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190721
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-09-17 Xisco Fauli <xiscofauli@libreoffice.org> [c5005923f103123a089ce24103cbe7b6d4627bac]
expat: upgrade to 2.7.2
Downloaded from https://github.com/libexpat/libexpat/releases/download/R_2_7_2/expat-2.7.2.tar.xz
Change-Id: Icf4b730291dfecc039024360b36c2fe8adb247fc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191047
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
(cherry picked from commit 953f1da9270dc10d4aa7852a91e22e4483751aba)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191054
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-09-17 Xisco Fauli <xiscofauli@libreoffice.org> [82975b83ecdac9256ee52bcd42b5cd394f8cb384]
nss: upgrade to 3.116
0001-Bug-1983399-lib-softtoken-sdb.c-sftkdbti.h-Align-sft.patch.1 has
been fixed upstream
Downloaded from https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_116_RTM/src/nss-3.116-with-nspr-4.37.tar.gz
Change-Id: I61f7efe779c89ca00e6698dd834cf282ea43f5d3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190960
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit c46712bcd7a6f811aa406f2db97d94d3d1b67350)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/190969
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-09-17 Stephan Bergmann <stephan.bergmann@collabora.com> [fb9337d51a3988f9b09aaca567b205a6917b9b4e]
external/freetype: Avoid signed-integer-overflow
...presumably after 981d8be918a7002ef4239244c8524dc73f0b5fd8 "freetype: upgrade
to 2.14.1", causing e.g. CppunitTest_chart2_pivot_chart_test to fail with
> workdir/UnpackedTarball/freetype/src/autofit/aflatin.c:3708:31: runtime error: signed integer overflow: 2161 - -9223372036854775808 cannot be represented in type 'FT_Pos' (aka 'long')
> #0 in af_glyph_hints_apply_vertical_separation_adjustments at workdir/UnpackedTarball/freetype/src/autofit/aflatin.c:3708:31
> #1 in af_latin_hints_apply at workdir/UnpackedTarball/freetype/src/autofit/aflatin.c:5054:9
> #2 in af_loader_load_glyph at workdir/UnpackedTarball/freetype/src/autofit/afloader.c:411:17
> #3 in af_autofitter_load_glyph at workdir/UnpackedTarball/freetype/src/autofit/afmodule.c:498:13
> #4 in FT_Load_Glyph at workdir/UnpackedTarball/freetype/src/base/ftobjs.c:1055:19
> #5 at <null> (/lib64/libcairo.so.2 +0x9be4b)
> #6 at <null> (/lib64/libcairo.so.2 +0xa0df1)
> #7 at <null> (/lib64/libcairo.so.2 +0x528b6)
> #8 at <null> (/lib64/libcairo.so.2 +0x57184)
> #9 at <null> (/lib64/libcairo.so.2 +0x179f6)
> #10 at <null> (/lib64/libcairo.so.2 +0x1a5f7)
> #11 at <null> (/lib64/libcairo.so.2 +0x27459)
> #12 at <null> (/lib64/libcairo.so.2 +0x701c8)
> #13 at <null> (/lib64/libcairo.so.2 +0x22a8b)
> #14 in cairo_show_glyphs at <null> (/lib64/libcairo.so.2 +0x78a7d)
> #15 in CairoTextRender::ImplDrawTextLayout(_cairo*, Color const&, GenericSalLayout const&, CairoCommon*, bool) at vcl/unx/generic/gdi/cairotextrender.cxx:517:9
> #16 in CairoTextRender::DrawTextLayout(GenericSalLayout const&, SalGraphics const&) at vcl/unx/generic/gdi/cairotextrender.cxx:292:5
> #17 in SvpSalGraphics::DrawTextLayout(GenericSalLayout const&) at vcl/headless/svptext.cxx:74:23
> #18 in GenericSalLayout::DrawText(SalGraphics&) const at vcl/source/gdi/CommonSalLayout.cxx:314:18
> #19 in OutputDevice::ImplDrawTextDirect(SalLayout&, bool) at vcl/source/outdev/text.cxx:311:16
> #20 in OutputDevice::ImplDrawText(SalLayout&) at vcl/source/outdev/text.cxx:464:9
> #21 in OutputDevice::DrawTextArray(Point const&, rtl::OUString const&, std::span<double const, 18446744073709551615ul>, std::span<unsigned char const, 18446744073709551615ul>, int, int, SalLayoutFlags, SalLayoutGlyphs const*) at vcl/source/outdev/text.cxx:750:9
> #22 in ScOutputData::LayoutStringsImpl(bool, RowInfo*, short, int, unsigned long, std::optional<short>&, std::optional<short>&, short, std::__debug::vector<std::unique_ptr<ScPatternAttr, std::default_delete<ScPatternAttr>>, std::allocator<std::unique_ptr<ScPatternAttr, std::default_delete<ScPatternAttr>>>>&, ScPatternAttr const*&, SfxItemSet const*&, SvtScriptType&, ScDrawStringsVars&, bool&, long, long, bool, bool&, vcl::PDFExtOutDevData*, long, std::__debug::vector<double, std::allocator<double>>&) ;at sc/source/ui/view/output2.cxx:2248:28
> #23 in ScOutputData::LayoutStrings(bool) at sc/source/ui/view/output2.cxx:1565:17
> #24 in ScOutputData::DrawStrings(bool) at sc/source/ui/view/output2.cxx:1487:5
> #25 in ScPrintFunc::DrawToDev(ScDocument&, OutputDevice*, double, tools::Rectangle const&, ScViewData&, bool) at sc/source/ui/view/printfun.cxx:604:17
> #26 in ScDocShell::Draw(OutputDevice*, JobSetup const&, unsigned short, bool) at sc/source/ui/docshell/docsh4.cxx:2656:9
> #27 in SfxObjectShell::DoDraw_Impl(OutputDevice*, Point const&, Fraction const&, Fraction const&, JobSetup const&, unsigned short, bool) at sfx2/source/doc/objembed.cxx:204:5
> #28 in SfxObjectShell::DoDraw(OutputDevice*, Point const&, Size const&, JobSetup const&, unsigned short, bool) at sfx2/source/doc/objembed.cxx:151:9
> #29 in SfxObjectShell::CreatePreview_Impl(bool, bool, VirtualDevice*, GDIMetaFile*) const at sfx2/source/doc/objcont.cxx:201:40
> #30 in SfxObjectShell::GetPreviewBitmap() const at sfx2/source/doc/objcont.cxx:113:9
> #31 in SfxObjectShell::WriteThumbnail(bool, com::sun::star::uno::Reference<com::sun::star::io::XStream> const&) at sfx2/source/doc/objstor.cxx:4157:29
> #32 in SfxObjectShell::GenerateAndStoreThumbnail(bool, com::sun::star::uno::Reference<com::sun::star::embed::XStorage> const&) at sfx2/source/doc/objstor.cxx:4112:33 | | |
